Skip to content

Commit 4140350

Browse files
committed
PR feedback; use INTEGER rather than UUID
1 parent 64ed235 commit 4140350

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

database/schema.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,5 +305,5 @@ sqlite> SELECT * FROM collector_config;
305305
306306
id target date_added last_heartbeat_at benchmark_set is_active
307307
--------- ------------------------- ------------- ---------------- --------- -------
308-
ea1f4e... aarch64-unknown-linux-gnu 2025-06-11... 2025-06-12 17... cea1bc... 0
308+
1 aarch64-unknown-linux-gnu 2025-06-11... 2025-06-12 17... 2 0
309309
```

database/src/pool/postgres.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -309,14 +309,14 @@ static MIGRATIONS: &[&str] = &[
309309
// Prevent multiple try commits without a `sha` and the same `pr` number
310310
// being added to the table
311311
r#"CREATE UNIQUE INDEX benchmark_request_pr_commit_type_idx ON benchmark_request (pr, commit_type) WHERE status != 'completed';"#,
312-
r#"CREATE EXTENSION IF NOT EXISTS "uuid-ossp";"#,
313312
r#"
314313
CREATE TABLE IF NOT EXISTS collector_config (
315-
id UUID PRIMARY KEY,
314+
id SERIAL PRIMARY KEY,
316315
target TEXT NOT NULL,
316+
name TEXT NOT NULL,
317317
date_added TIMESTAMPTZ DEFAULT NOW() NOT NULL,
318318
last_heartbeat_at TIMESTAMPTZ,
319-
benchmark_set UUID NOT NULL,
319+
benchmark_set INTEGER NOT NULL,
320320
is_active BOOLEAN DEFAULT FALSE NOT NULL
321321
);
322322
"#,

database/src/pool/sqlite.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -408,11 +408,12 @@ static MIGRATIONS: &[Migration] = &[
408408
Migration::without_foreign_key_constraints(
409409
r#"
410410
CREATE TABLE IF NOT EXISTS collector_config (
411-
id TEXT PRIMARY KEY,
411+
id INTEGER AUTO INCREMENT PRIMARY KEY,
412412
target TEXT NOT NULL,
413+
name TEXT NOT NULL,
413414
date_added TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL,
414415
last_heartbeat_at TIMESTAMP,
415-
benchmark_set TEXT NOT NULL,
416+
benchmark_set INTEGER NOT NULL,
416417
is_active BOOLEAN DEFAULT FALSE NOT NULL
417418
);
418419
"#,

0 commit comments

Comments
 (0)