Rollup of 15 pull requests #148931
Merged
Rollup of 15 pull requests #148931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an incremental step towards making the expansion tree central to coverage mapping creation, which will be needed for proper expansion region support.
This also replaces `push_covspan` with a separate covspan-filtering step, because the relevant code is being reindented anyway.
This will make it easier to perform span refinement for child expansions.
The CStr docs used to say things about CStr that are only true for &CStr. Also, it's the bytes that are being borrowed, not the reference. One could say that it's the reference that is doing the borrowing, rather than being borrowed.
Tracking issue: rust-lang#148848
There are only two call sites, and three of the arguments are identical at both call sites. This commit removes those arguments and renames the method accordingly.
It's `true` at all call sites.
... outside `tests/ui/never_type/`
…sociated_functions, r=lolbinarycat Correctly link to associated trait items in reexports Fixes rust-lang#148008. Issue was that we didn't add anchors in this case. r? ``````@lolbinarycat``````
…enyukang,petrochenkov Some resolve cleanups Minor improvements I found while looking over this code. r? ```````@petrochenkov```````
…uwer coverage: Associate hole spans with expansion tree nodes This PR is another incremental step towards expansion region support in coverage instrumentation. When preparing coverage mappings for a function, we extract “raw” spans from MIR, and then use “hole” spans extracted from HIR to avoid overlap with nested items and closures. That hole-carving process was historically built around the assumption that there would be one set of spans and holes per function, but expansion region support will need to invalidate that assumption. Therefore, to be more friendly to future work on expansion regions, this PR associates each hole span with its corresponding node in the expansion tree, and makes the span refinement step obtain holes from the current node. There should be no change to compiler output.
CStr docs: Fix CStr vs &CStr confusion The CStr documentation used to say things about CStr that are only true for &CStr. Also, it's the bytes that are being borrowed, not the reference. One could say that it's the reference that is doing the borrowing, rather than being borrowed.
Implement `Read::read_array` Tracking issue: rust-lang#148848
Refactor `Box::take` as per rust-lang#147227 (comment)
…rsion, r=WaffleLapkin add assembly test for infinite recursion with `become` tracking issue: rust-lang#112788 fixes rust-lang#125698 Check that infinite recursion via `become` does not grow the stack (even on opt-level 0). The incomplete implementation of `become` did not guarantee that earlier. Although it's unlikely this ever regresses we may as well test it and close the issue. r? ```@WaffleLapkin```
Move & adjust some `!`-adjacent tests I'm trying to clean up tests relating to the never type...
…=mati865,jieyouxu ignore `build-rust-analyzer` even if it's a symlink r? `@jieyouxu`
rustbot
added
A-LLVM
Member
Author
|
Rollup of everything. @bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
@bors try jobs=x86_64-gnu-aux |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 15 pull requests try-job: x86_64-gnu-aux
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 6d41834 (parent) -> c880acd (this PR) Test differencesShow 338 test diffsStage 1
Stage 2
Additionally, 324 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard c880acdd3171dfafdb55be8cd9822a857e99348d --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 6d41834e25 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (c880acd): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 476.969s -> 473.179s (-0.79%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Read::read_array#148850 (ImplementRead::read_array)Box::take#148867 (RefactorBox::take)become#148907 (add assembly test for infinite recursion withbecome)!-adjacent tests #148928 (Move & adjust some!-adjacent tests)build-rust-analyzereven if it's a symlink #148929 (ignorebuild-rust-analyzereven if it's a symlink)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup