Skip to content

Remove unused LLVMModuleRef argument #148870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2025
Merged

Remove unused LLVMModuleRef argument #148870

merged 1 commit into from
Nov 14, 2025

Conversation

@QnnOkabayashi
Copy link
Contributor

@QnnOkabayashi QnnOkabayashi commented Nov 12, 2025

No description provided.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 12, 2025
@QnnOkabayashi QnnOkabayashi marked this pull request as ready for review November 12, 2025 15:50
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 12, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 12, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@wesleywiser
Copy link
Member

wesleywiser commented Nov 13, 2025

Thanks @QnnOkabayashi!

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 13, 2025

📌 Commit c7e50d0 has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge of rust-lang#148870 - QnnOkabayashi:remove-unused-value,…
eaa7a7c 
… r=wesleywiser

Remove unused LLVMModuleRef argument
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge of rust-lang#148870 - QnnOkabayashi:remove-unused-value,…
299c4fd 
… r=wesleywiser

Remove unused LLVMModuleRef argument
@Zalathar Zalathar mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 14, 2025
@bors
Auto merge of #148927 - Zalathar:rollup-fpodxsi, r=Zalathar
323450f 
Rollup of 14 pull requests

Successful merges:

 - #146978 (Emit error when using path-segment keyword as cfg pred)
 - #148543 (Correctly link to associated trait items in reexports)
 - #148808 (Some resolve cleanups)
 - #148812 (coverage: Associate hole spans with expansion tree nodes )
 - #148826 (CStr docs: Fix CStr vs &CStr confusion)
 - #148850 (Implement `Read::read_array`)
 - #148867 (Refactor `Box::take`)
 - #148870 (Remove unused LLVMModuleRef argument)
 - #148878 (error when ABI does not support guaranteed tail calls)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)
 - #148902 (add missing s390x target feature to std detect test)
 - #148904 (waffle: stop watching codegen ssa)
 - #148906 (Expose fmt::Arguments::from_str as unstable.)
 - #148907 (add assembly test for infinite recursion with `become`)

r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 14, 2025
@Zalathar
Rollup merge of rust-lang#148870 - QnnOkabayashi:remove-unused-value,…
4dda4c9 
… r=wesleywiser

Remove unused LLVMModuleRef argument
@Zalathar Zalathar mentioned this pull request Nov 14, 2025
Merged
@Zalathar
Copy link
Member

Zalathar commented Nov 14, 2025

cc @ZuseZ4

For context, it looks like LLVMRustOffloadMapper was introduced in #145768, but the module argument wasn't actually used by the merged version of that PR. I'm guessing it was left over from earlier drafts of that PR that did more work on the C++ side.

@ZuseZ4
Copy link
Member

ZuseZ4 commented Nov 14, 2025

@Zalathar seems likely. I first wrote it all in C++, and then raised as much as possible back to Rust. Thanks!

bors added a commit that referenced this pull request Nov 14, 2025
@bors
Auto merge of #148931 - Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd 
Rollup of 15 pull requests

Successful merges:

 - #148543 (Correctly link to associated trait items in reexports)
 - #148808 (Some resolve cleanups)
 - #148812 (coverage: Associate hole spans with expansion tree nodes )
 - #148826 (CStr docs: Fix CStr vs &CStr confusion)
 - #148850 (Implement `Read::read_array`)
 - #148867 (Refactor `Box::take`)
 - #148870 (Remove unused LLVMModuleRef argument)
 - #148878 (error when ABI does not support guaranteed tail calls)
 - #148901 (Disable rustdoc-test-builder test partially for SGX target.)
 - #148902 (add missing s390x target feature to std detect test)
 - #148904 (waffle: stop watching codegen ssa)
 - #148906 (Expose fmt::Arguments::from_str as unstable.)
 - #148907 (add assembly test for infinite recursion with `become`)
 - #148928 (Move & adjust some `!`-adjacent tests)
 - #148929 (ignore `build-rust-analyzer` even if it's a symlink)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9f07b25 into rust-lang:main Nov 14, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 14, 2025
rust-timer added a commit that referenced this pull request Nov 14, 2025
@rust-timer
Unrolled build for #148870
3e14bee 
Rollup merge of #148870 - QnnOkabayashi:remove-unused-value, r=wesleywiser

Remove unused LLVMModuleRef argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleywiser wesleywiser wesleywiser approved these changes

Assignees

@davidtwco davidtwco

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@QnnOkabayashi @rustbot @wesleywiser @bors @Zalathar @ZuseZ4 @davidtwco