Skip to content

bors should not try to merge a PR if the CI has failed #67

@varkor

Description

@varkor
Member

In the rare occasions we might want to merge even if CI has failed, we should explicitly command @bors to ignore the CI failure.

Activity

Mark-Simulacrum

Mark-Simulacrum commented on Sep 27, 2019

@Mark-Simulacrum
Member

Why would this ever be the case? I'm quite confused -- is there some context here? Bors does check the CI status (otherwise, you know, there'd be no point...?)

varkor

varkor commented on Sep 27, 2019

@varkor
MemberAuthor

Sorry, I thought someone indicated otherwise, and I must have misunderstood.

Mark-Simulacrum

Mark-Simulacrum commented on Sep 27, 2019

@Mark-Simulacrum
Member

Discussed briefly on Discord. Turns out @varkor presumably meant that if the PR CI fails, we should not then go and try to test on auto branch CI, since that's probably a waste of time.

RalfJung

RalfJung commented on Dec 3, 2019

@RalfJung
Member

Yeah, it would be great if bors either waited until PR CI passed before adding the PR to the queue, or else de-queued PRs (auto-bors r-) when PR CI fails.

jyn514

jyn514 commented on Apr 30, 2021

@jyn514
Member

Maybe easier to implement - if bors could show on the queue that PR CI failed, it would at least let people know it wouldn't be included in rollups: rust-lang/rust#84716 (comment)

jackh726

jackh726 commented on Apr 30, 2021

@jackh726
Member

Or better: if CI fails, then it automatically gets r-ed

Oh that was said

camelid

camelid commented on Apr 30, 2021

@camelid
Member

Another approach to this is r+ await (#120).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @RalfJung@varkor@Mark-Simulacrum@jyn514@jackh726

        Issue actions

          bors should not try to merge a PR if the CI has failed · Issue #67 · rust-lang/homu