You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Why would this ever be the case? I'm quite confused -- is there some context here? Bors does check the CI status (otherwise, you know, there'd be no point...?)
Discussed briefly on Discord. Turns out @varkor presumably meant that if the PR CI fails, we should not then go and try to test on auto branch CI, since that's probably a waste of time.
Yeah, it would be great if bors either waited until PR CI passed before adding the PR to the queue, or else de-queued PRs (auto-bors r-) when PR CI fails.
Maybe easier to implement - if bors could show on the queue that PR CI failed, it would at least let people know it wouldn't be included in rollups: rust-lang/rust#84716 (comment)
Activity
Mark-Simulacrum commentedon Sep 27, 2019
Why would this ever be the case? I'm quite confused -- is there some context here? Bors does check the CI status (otherwise, you know, there'd be no point...?)
varkor commentedon Sep 27, 2019
Sorry, I thought someone indicated otherwise, and I must have misunderstood.
Mark-Simulacrum commentedon Sep 27, 2019
Discussed briefly on Discord. Turns out @varkor presumably meant that if the PR CI fails, we should not then go and try to test on auto branch CI, since that's probably a waste of time.
RalfJung commentedon Dec 3, 2019
Yeah, it would be great if bors either waited until PR CI passed before adding the PR to the queue, or else de-queued PRs (auto-
bors r-
) when PR CI fails.jyn514 commentedon Apr 30, 2021
Maybe easier to implement - if bors could show on the queue that PR CI failed, it would at least let people know it wouldn't be included in rollups: rust-lang/rust#84716 (comment)
jackh726 commentedon Apr 30, 2021
Or better: if CI fails, then it automatically gets
r-
edOh that was said
camelid commentedon Apr 30, 2021
Another approach to this is
r+ await
(#120).auto-approve
label rust-lang/rust#100876