-
Notifications
You must be signed in to change notification settings - Fork 668
Open
Feature Request
Copy link
Labels
A-accessibilityA-frontend 🐹C-enhancement ✨Category: Adding new behavior or a change to the way an existing feature worksCategory: Adding new behavior or a change to the way an existing feature worksE-help-wanted
Description
Once #1227 is merged in, address this comment:
There are multiple elements that currently fail this test. I have disabled it since I think it needs to be addressed by someone more inclined towards design.
by changing tests/axe-config.js to remove:
'color-contrast': {
enabled: false,
}
run npm test
and make changes to fix all violations where we're using colors that don't contrast enough.
Metadata
Metadata
Assignees
Labels
A-accessibilityA-frontend 🐹C-enhancement ✨Category: Adding new behavior or a change to the way an existing feature worksCategory: Adding new behavior or a change to the way an existing feature worksE-help-wanted
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
sorin-davidoi commentedon Jan 14, 2018
Colorable can be handy when testing new colour combinations.
p-jackson commentedon Jan 22, 2019
I had this idea to use font size and weight to communicate information hierarchy rather than using grey (specifically
$main-color-light
)Notice the changes to the version number in the heading and the metadata titles on the right.
Dealing with the hyperlink colour is trickier. It's very hard to pick greens with sufficient contrast. There's a reason why blue hyperlinks are ubiquitous ;)
Update link and body colors to have a contrast ratio of 7:1 (WCAG AAA…