test: update_precise_breaking_direct_plus_transitive

Author: torhovland

src/cargo/ops/cargo_update.rs

@@ -109,12 +109,13 @@ pub fn update_lockfile(
     };
     let mut registry = ws.package_registry()?;
     let mut to_avoid = HashSet::new();
+    let breaking_update = !upgrades.is_empty();
 
-    if opts.breaking {
+    if breaking_update {
         // We don't necessarily want to update all specified packages. If we are
-        // doing a breaking update (or precise upgrades, coming in #14140), we
-        // don't want to touch any packages that have no breaking updates. So we
-        // want to only avoid all packages that got upgraded.
+        // doing a breaking update or precise upgrade, we don't want to touch
+        // any packages that have no breaking updates. So we want to only avoid
+        // all packages that got upgraded.
 
         for name in opts.to_update.iter() {
             // We still want to query any specified package, for the sake of

tests/testsuite/update.rs

@@ -2564,6 +2564,68 @@ perhaps a crate was updated and forgotten to be re-vendored?
         .run();
 }
 
+#[cargo_test]
+fn update_precise_breaking_direct_plus_transitive() {
+    Package::new("incompatible", "1.0.0").publish();
+
+    let p = project()
+        .file(
+            "Cargo.toml",
+            r#"
+                # Check if formatting is preserved
+
+                [package]
+                name  =  "foo"
+                version  =  "0.0.1"
+                edition  =  "2015"
+                authors  =  []
+
+                [dependencies]
+                incompatible  =  "1.0"  # Comment
+                bar = { path = "bar" }
+            "#,
+        )
+        .file("src/lib.rs", "")
+        .file(
+            "bar/Cargo.toml",
+            r#"
+                [package]
+                name = "bar"
+                version = "0.0.1"
+                edition = "2015"
+                authors = []
+
+                [dependencies]
+                incompatible = "1.0"
+            "#,
+        )
+        .file("bar/src/lib.rs", "")
+        .build();
+
+    p.cargo("generate-lockfile").run();
+    let lock1 = p.read_lockfile();
+
+    Package::new("incompatible", "2.0.0").publish();
+    Package::new("incompatible", "2.0.1").publish();
+
+    p.cargo("update -Zunstable-options incompatible --precise 2.0.0")
+        .masquerade_as_nightly_cargo(&["update-precise-breaking"])
+        .with_stderr_data(str![[r#"
+[UPGRADING] incompatible ^1.0 -> ^2.0
+[UPDATING] `dummy-registry` index
+[ADDING] incompatible v2.0.0 (latest: v2.0.1)
+[NOTE] pass `--verbose` to see 1 unchanged dependencies behind latest
+
+"#]])
+        .run();
+
+    let lock2 = p.read_lockfile();
+
+    assert_ne!(lock1, lock2);
+    assert!(lock2.contains("incompatible 1.0.0"));
+    assert!(lock2.contains("incompatible 2.0.0"));
+}
+
 #[cargo_test]
 fn update_precise_breaking_incompatible_downgrade() {
     Package::new("incompatible", "1.0.0").publish();