ci: samcli automation fixes (#339)

Minor fixes for SAMcli automation workflows, including better failure handling and explicit role duration.

Signed-off-by: ayush-panta <[email protected]>

Author: ayush-panta

.github/workflows/samcli-direct.yaml

@@ -1,9 +1,8 @@
 name: samcli-direct
 
 on:
-  pull_request:
-    branches:
-      - main
+  schedule:
+    - cron: '0 8 * * *'
   workflow_dispatch:
 
 env:

.github/workflows/samcli-vm.yaml

@@ -1,9 +1,6 @@
 name: samcli-vm
 
 on:
-  pull_request:
-    branches:
-      - main
   schedule:
     - cron: '0 8 * * *'
   workflow_dispatch:
@@ -138,6 +135,7 @@ jobs:
           role-to-assume: ${{ secrets.SAMCLI_VM_ROLE_SYNC }}
           role-session-name: samcli-finch-vm-sequential-tests
           aws-region: ${{ secrets.REGION }}
+          role-duration-seconds: 14400
 
       - name: Install Docker CLI for SAM CLI compatibility
         run: |
@@ -172,34 +170,50 @@ jobs:
 
       - name: Run unit tests
         continue-on-error: true
-        run: ./scripts/samcli-vm/run-unit-tests.sh
+        run: |
+          ./scripts/samcli-vm/run-unit-tests.sh
+          echo "UNIT_EXIT_CODE=$(cat /tmp/unit_exit_code 2>/dev/null || echo 1)" >> $GITHUB_ENV
 
       - name: Run sync tests
         continue-on-error: true
-        run: ./scripts/samcli-vm/run-sync-tests.sh
+        run: |
+          ./scripts/samcli-vm/run-sync-tests.sh
+          echo "SYNC_EXIT_CODE=$(cat /tmp/sync_exit_code 2>/dev/null || echo 1)" >> $GITHUB_ENV
 
       - name: Run package tests
         continue-on-error: true
-        run: ./scripts/samcli-vm/run-package-tests.sh
+        run: |
+          ./scripts/samcli-vm/run-package-tests.sh
+          echo "PACKAGE_EXIT_CODE=$(cat /tmp/package_exit_code 2>/dev/null || echo 1)" >> $GITHUB_ENV
 
       - name: Run start-api tests
         continue-on-error: true
-        run: ./scripts/samcli-vm/run-start-api-tests.sh
+        run: |
+          ./scripts/samcli-vm/run-start-api-tests.sh
+          echo "START_API_EXIT_CODE=$(cat /tmp/start_api_exit_code 2>/dev/null || echo 1)" >> $GITHUB_ENV
 
       - name: Run start-lambda tests
         continue-on-error: true
-        run: ./scripts/samcli-vm/run-start-lambda-tests.sh
+        run: |
+          ./scripts/samcli-vm/run-start-lambda-tests.sh
+          echo "START_LAMBDA_EXIT_CODE=$(cat /tmp/start_lambda_exit_code 2>/dev/null || echo 1)" >> $GITHUB_ENV
 
       - name: Patch SAM CLI for Docker image cleanup
         continue-on-error: true
         run: |
           # Apply git patch to handle ImageNotFound exceptions for all Docker tests
           su ec2-user -c 'cd /Users/ec2-user/aws-sam-cli && git apply ${{ github.workspace }}/scripts/samcli-vm/invoke-teardown.patch'
+          echo "PATCH_EXIT_CODE=$?" >> $GITHUB_ENV
         shell: bash
 
       - name: Run invoke tests
         continue-on-error: true
-        run: ./scripts/samcli-vm/run-invoke-tests.sh
+        run: |
+          ./scripts/samcli-vm/run-invoke-tests.sh
+          echo "INVOKE_EXIT_CODE=$(cat /tmp/invoke_exit_code 2>/dev/null || echo 1)" >> $GITHUB_ENV
+
+      - name: Check test results
+        run: ./scripts/samcli-vm/check-test-results.sh
 
   # ensuring resources are clean post-test
   cleanup:

scripts/samcli-vm/check-test-results.sh

@@ -0,0 +1,19 @@
+#!/bin/bash
+set -e
+
+echo "=== Test Results Summary ==="
+echo "Unit tests: ${UNIT_EXIT_CODE:-1}"
+echo "Sync tests: ${SYNC_EXIT_CODE:-1}"
+echo "Package tests: ${PACKAGE_EXIT_CODE:-1}"
+echo "Start-API tests: ${START_API_EXIT_CODE:-1}"
+echo "Start-Lambda tests: ${START_LAMBDA_EXIT_CODE:-1}"
+echo "Patch: ${PATCH_EXIT_CODE:-1}"
+echo "Invoke tests: ${INVOKE_EXIT_CODE:-1}"
+
+# Check if any tests failed
+if [ "${UNIT_EXIT_CODE:-1}" -ne 0 ] || [ "${SYNC_EXIT_CODE:-1}" -ne 0 ] || [ "${PACKAGE_EXIT_CODE:-1}" -ne 0 ] || [ "${START_API_EXIT_CODE:-1}" -ne 0 ] || [ "${START_LAMBDA_EXIT_CODE:-1}" -ne 0 ] || [ "${PATCH_EXIT_CODE:-1}" -ne 0 ] || [ "${INVOKE_EXIT_CODE:-1}" -ne 0 ]; then
+  echo "❌ One or more tests failed"
+  exit 1
+else
+  echo "✅ All tests passed"
+fi