From 2f3776d1b38c08ddf9865bca8ecf6b007e8d3b89 Mon Sep 17 00:00:00 2001 From: Maxim Masiutin Date: Fri, 16 May 2025 16:39:23 +0300 Subject: [PATCH] Empty URL misrepresented as misconfiguration in the log (fixed #5585). Signed-off-by: Maxim Masiuitn Signed-off-by: Maxim Masiutin --- server/events/vcs/instrumented_client.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/server/events/vcs/instrumented_client.go b/server/events/vcs/instrumented_client.go index d8553c4bc4..9a39a97007 100644 --- a/server/events/vcs/instrumented_client.go +++ b/server/events/vcs/instrumented_client.go @@ -217,7 +217,13 @@ func (c *InstrumentedClient) UpdateStatus(logger logging.SimpleLogging, repo mod if err := c.Client.UpdateStatus(logger, repo, pull, state, src, description, url); err != nil { executionError.Inc(1) - logger.Err("Unable to update status at url: %s, error: %s", url, err.Error()) + if url == "" && src != "" { + logger.Err("Unable to update status (from '%s'), error: %s", src, err.Error()) + } else if url != "" { + logger.Err("Unable to update status at url: %s, error: %s", url, err.Error()) + } else { + logger.Err("Unable to update status, error: %s", err.Error()) + } return err }