Skip to content

fix: empty URL misrepresented as misconfiguration in the log #5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: empty URL misrepresented as misconfiguration in the log #5586

wants to merge 1 commit into from

Conversation

maximmasiutin
Copy link

@maximmasiutin maximmasiutin commented May 16, 2025 •
edited by nitrocode
Loading

@github-actions github-actions bot added the go Pull requests that update Go code label May 16, 2025
@maximmasiutin maximmasiutin mentioned this pull request May 16, 2025
Open
@maximmasiutin maximmasiutin changed the title Empty URL misrepresented as misconfiguration in the log fix: empty URL misrepresented as misconfiguration in the log May 16, 2025
@maximmasiutin maximmasiutin force-pushed the feature/fix-5585 branch 2 times, most recently from 9b577df to 936ce19 Compare May 16, 2025 13:39
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 17, 2025
@nitrocode
Copy link
Member

@maximmasiutin any chance you can add a test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github update status error is logged with empty URL as if there were misconfiguration
2 participants
@maximmasiutin @nitrocode