Documentation Error: Gitlab Webhook Configuration - Push Events are not required

[saraangelmurphy]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

In the Atlantis documentation, when configuring webhooks, Atlantis tells the end user to enable push events.

https://www.runatlantis.io/docs/configuring-webhooks#gitlab

However, we can clearly see in handleGitlabPost and ParseAndValidate that only "Merge Request Hook" and "Note Hook" events are actually parsed. Push events have a header of "Push Hook" (see the gitlab sample docs).

Reproduction Steps

1. Configure a gitlab webhook as per the normal instructions
2. Disable push events

Logs

Environment details

• Atlantis version: v0.34.0
• Deployment method: helm 5.17.2
• If not running the latest Atlantis version have you tried to reproduce this issue on the latest version:
• Atlantis flags:

Atlantis server-side config file:

irrelevant for this issue.

Repo atlantis.yaml file:

Additional Context

[dosubot]

The issue you've identified highlights a discrepancy in the Atlantis documentation regarding GitLab webhook configuration. The documentation suggests enabling push events, but the actual implementation of Atlantis only parses "Merge Request Hook" and "Note Hook" events, not "Push Hook" events. This is confirmed by the handleGitlabPost function and the ParseAndValidate function, which do not process "Push Hook" events ^[1][2].

To address this, you can safely disable push events in your GitLab webhook configuration, as they are not required for Atlantis to function correctly. The documentation should be updated to reflect this and avoid confusion for users setting up their webhooks.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}