Repository navigation
Request Item → Item Request - #5196
Conversation
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
Minor suggestion, otherwise looks good. 🎉
| def name_with_unit(quantity_override = nil) | ||
| if Flipper.enabled?(:enable_packs) && request_unit.present? | ||
| "#{item&.name || name} - #{request_unit.pluralize(quantity_override || quantity.to_i)}" | ||
| "#{item_name} - #{request_unit.pluralize(quantity_override || quantity.to_i)}" |
There was a problem hiding this comment.
I think you forgot to use the new method here? :)
There was a problem hiding this comment.
This is one of the display helpers:
- ItemRequest#item_name gives the item's name and falls back to the local copy
- ItemRequest#quantity_with_units shows the qty and units but not the name
- ItemRequest#name_with_unit shows the name and the unit but not qty
|
@janeewheatley @awwaiid yep, my most recent comments have not been addressed. |
|
@dorner mmmm I think the one you mentioned shouldn't or can't use the other display helper (and this is a different display helper). Eh? |
dorner
left a comment
dorner
left a comment
There was a problem hiding this comment.
I don't honestly remember much about this but I'm good with the very last interaction 😂 This is good for a manual test.
|
@awwaiid: Your PR |
4 participants
First pass at removing
request_itemeverywhere.