fix visibility

Author: grosser

lib/rack/openid.rb

@@ -93,12 +93,7 @@ def initialize(app, store = nil)
     def call(env)
       req = Rack::Request.new(env)
 
-      # Stop the base64 encoded nonce and sig from having its +'s
-      # transformed into spaces by Rack::Request.
-      #
-      # See https://github.com/openid/ruby-openid/pull/54
-      #
-      Rack::OpenID.sanitize_params!(req.params)
+      sanitize_params!(req.params)
 
       if req.params["openid.mode"]
         complete_authentication(env)
@@ -114,13 +109,14 @@ def call(env)
       end
     end
 
-    def self.sanitize_params!(params)
-      ['openid.sig', 'openid.response_nonce'].each do |param|
-        (params[param] || '').gsub!(' ', '+')
+    private
+
+      def sanitize_params!(params)
+        ['openid.sig', 'openid.response_nonce'].each do |param|
+          (params[param] || '').gsub!(' ', '+')
+        end
       end
-    end
 
-    private
       def begin_authentication(env, qs)
         req = Rack::Request.new(env)
         params = self.class.parse_header(qs)

test/test_rack_openid.rb

@@ -1,15 +1,19 @@
 require File.expand_path("../helper", __FILE__)
 
 describe Rack::OpenID do
-  describe ".sanitize_request" do
-    # https://github.com/grosser/rack-openid/pull/4
-    it "fixes sig and nonce encoding issues" do
+  describe ".sanitize_params!" do
+    def call(*args)
+      Rack::OpenID.new(nil, nil).send(:sanitize_params!, *args)
+    end
+
+    # https://github.com/openid/ruby-openid/pull/54
+    it "stops the base64 encoded nonce and sig from having its +'s transformed into spaces by Rack::Request" do
       params = {
         "openid.sig" => "a string with spaces",
         "openid.response_nonce" => "again with spaces!",
       }
 
-      Rack::OpenID.sanitize_params!(params)
+      call(params)
 
       params["openid.sig"].must_equal "a+string+with+spaces"
       params["openid.response_nonce"].must_equal "again+with+spaces!"