Fixed error related to ImGui::Image and sampler creation. Note : The sampler bug was related to using a COMPARISON_FUNC_LESS while using a ANISOTROPIC filter, which caused errors while using the latest agility SDK. The Imgui::image bug was caused due to using CPU descriptor handles rather than GPU handles

Author: rtarun9

Helios/Source/Editor/Editor.cpp

@@ -188,7 +188,7 @@ namespace helios::editor
                                 graphicsDevice->getCbvSrvUavDescriptorHeap()->getDescriptorHandleFromIndex(
                                     material[i].albedoTexture.srvIndex);
 
-                            ImGui::Image((ImTextureID)(albedoSrvHandle.cpuDescriptorHandle.ptr), ImVec2(60, 60));
+                            ImGui::Image((ImTextureID)(albedoSrvHandle.gpuDescriptorHandle.ptr), ImVec2(60, 60));
                         }
 
                         ImGui::SliderFloat("Roughness Factor", &material[i].materialBufferData.roughnessFactor, 0.0f,
@@ -313,7 +313,7 @@ namespace helios::editor
         //         deferredGBuffer.aoMetalRoughnessEmissiveRT.srvIndex);
 
         ImGui::Begin("Albedo RT");
-        ImGui::Image((ImTextureID)(albedoEmissiveDescriptorHandle.cpuDescriptorHandle.ptr),
+        ImGui::Image((ImTextureID)(albedoEmissiveDescriptorHandle.gpuDescriptorHandle.ptr),
                      ImGui::GetWindowViewport()->WorkSize);
         ImGui::End();
 
@@ -341,7 +341,7 @@ namespace helios::editor
             shadowMappingPass.m_shadowDepthBuffer.srvIndex);
 
         ImGui::Begin("Shadow Depth Map");
-        ImGui::Image((ImTextureID)(srvDescriptorHandle.cpuDescriptorHandle.ptr), ImGui::GetWindowViewport()->WorkSize);
+        ImGui::Image((ImTextureID)(srvDescriptorHandle.gpuDescriptorHandle.ptr), ImGui::GetWindowViewport()->WorkSize);
         ImGui::End();
 
         ImGui::SliderFloat("Backoff distance", &shadowMappingPass.m_shadowBufferData.backOffDistance, 0.0f, 300.0f);
@@ -361,7 +361,7 @@ namespace helios::editor
                 ssaoPass.m_blurSSAOTexture.srvIndex);
 
         ImGui::Begin("SSAO Blur Texture");
-        ImGui::Image((ImTextureID)(blurSSAOTextureSrvDescriptorHandle.cpuDescriptorHandle.ptr),
+        ImGui::Image((ImTextureID)(blurSSAOTextureSrvDescriptorHandle.gpuDescriptorHandle.ptr),
                      ImGui::GetWindowViewport()->WorkSize);
         ImGui::End();
 
@@ -385,7 +385,7 @@ namespace helios::editor
                 bloomPass.m_extractionTexture.srvIndex);
 
          ImGui::Begin("Bloom Extract Texture");
-         ImGui::Image((ImTextureID)(bloomExtractTextureSrvDescriptorHandle.cpuDescriptorHandle.ptr),
+         ImGui::Image((ImTextureID)(bloomExtractTextureSrvDescriptorHandle.gpuDescriptorHandle.ptr),
                       ImGui::GetMainViewport()->WorkSize);
          ImGui::End();
 
@@ -397,7 +397,7 @@ namespace helios::editor
                 bloomPass.m_bloomDownSampleTexture.srvIndex + bloomDownSampleMipIndex);
 
         ImGui::Begin("Bloom Downsample Texture");
-        ImGui::Image((ImTextureID)(bloomDownPassTextureSrvDescriptorHandle.cpuDescriptorHandle.ptr),
+        ImGui::Image((ImTextureID)(bloomDownPassTextureSrvDescriptorHandle.gpuDescriptorHandle.ptr),
                      ImGui::GetWindowViewport()->WorkSize);
         ImGui::End();
 
@@ -409,7 +409,7 @@ namespace helios::editor
                 bloomPass.m_bloomUpSampleTexture.srvIndex + bloomUpSampleMipIndex);
 
         ImGui::Begin("Bloom UpSample Texture");
-        ImGui::Image((ImTextureID)(bloomUpSampleTextureSrvDescriptorHandle.cpuDescriptorHandle.ptr),
+        ImGui::Image((ImTextureID)(bloomUpSampleTextureSrvDescriptorHandle.gpuDescriptorHandle.ptr),
                      ImGui::GetWindowViewport()->WorkSize);
         ImGui::End();
 
@@ -436,7 +436,7 @@ namespace helios::editor
             graphicsDevice->getCbvSrvUavDescriptorHeap()->getDescriptorHandleFromIndex(renderTarget.srvIndex);
 
         ImGui::Begin("View Port");
-        ImGui::Image((ImTextureID)(rtvSrvHandle.cpuDescriptorHandle.ptr), ImGui::GetWindowViewport()->WorkSize);
+        ImGui::Image((ImTextureID)(rtvSrvHandle.gpuDescriptorHandle.ptr), ImGui::GetWindowViewport()->WorkSize);
 
         // Handling the drag-drop facility for GLTF models.
         if (ImGui::BeginDragDropTarget())

Helios/Source/Graphics/GraphicsDevice.cpp

@@ -630,6 +630,8 @@ namespace helios::gfx
 
         m_device->CreateSampler(&samplerCreationDesc.samplerDesc, samplerDescriptorHandle.cpuDescriptorHandle);
 
+        m_samplerDescriptorHeap->offsetCurrentHandle();
+
         return sampler;
     }
 

Helios/Source/Scene/Model.cpp

@@ -521,7 +521,7 @@ namespace helios::scene
             samplerCreationDesc.samplerDesc.MinLOD = 0.0f;
             samplerCreationDesc.samplerDesc.MipLODBias = 0.0f;
             samplerCreationDesc.samplerDesc.MaxAnisotropy = 16;
-            samplerCreationDesc.samplerDesc.ComparisonFunc = D3D12_COMPARISON_FUNC_LESS_EQUAL;
+            samplerCreationDesc.samplerDesc.ComparisonFunc = D3D12_COMPARISON_FUNC_NEVER;
 
             m_samplers[index++] = graphicsDevice->createSampler(samplerCreationDesc);
         }

README.md

@@ -84,6 +84,8 @@ cmake --build Build --config Release
 Alternatively open the folder in Visual Studio's open folder mode.
 + Run the `Setup.bat` file, which will install the DirectXAgility SDK and the DirectXShader Compiler. You will be asked to enter the build path, which was the same path you gave in cmake -S . -B 'BuildPath'. If you followed the commands above, BuildPath = Build.
 
+NOTE : Since a preview version of Agility SDK is currently being used, you need to enable Developer Mode for the application to run.
+
 # Controls
 + WASD -> Move camera.
 + Arrow keys -> Modify camera orientation.

imgui.ini

@@ -274,7 +274,7 @@ DockSpace         ID=0x8B93E3BD Window=0xA787BDB4 Pos=0,19 Size=1536,845 Split=X
       DockNode    ID=0x0000000C Parent=0x00000001 SizeRef=239,243 Selected=0x39863C79
     DockNode      ID=0x00000002 Parent=0x00000009 SizeRef=1035,845 Split=Y Selected=0x6EE523C4
       DockNode    ID=0x00000005 Parent=0x00000002 SizeRef=1389,697 CentralNode=1 Selected=0x6EE523C4
-      DockNode    ID=0x00000006 Parent=0x00000002 SizeRef=1389,146 Selected=0x20E3C5EA
+      DockNode    ID=0x00000006 Parent=0x00000002 SizeRef=1389,146 Selected=0xBF096F38
   DockNode        ID=0x0000000A Parent=0x8B93E3BD SizeRef=275,845 Split=Y Selected=0xBEC9F81A
     DockNode      ID=0x00000007 Parent=0x0000000A SizeRef=194,418 Selected=0xBEC9F81A
     DockNode      ID=0x00000008 Parent=0x0000000A SizeRef=194,425 Selected=0x8477D764