Skip to content

Commit a0ed421

Browse files
committed
Making pause to be an unpersisted operation
1 parent 1bcb129 commit a0ed421

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

nprogress.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,11 +179,11 @@
179179
};
180180

181181
NProgress.continue = function() {
182-
return NProgress.configure({isPaused: true});
182+
return NProgress.configure({isPaused: false});
183183
}
184184

185185
NProgress.pause = function() {
186-
return NProgress.configure({isPaused: false});
186+
return NProgress.configure({isPaused: true});
187187
}
188188

189189
NProgress.trickle = function() {

test/test.js

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -172,20 +172,8 @@
172172
});
173173

174174
describe('.pause()', function() {
175-
it('should be able to create paused nprogress', function(done) {
176-
this.timeout(600)
177-
NProgress.pause();
178-
NProgress.start();
179-
NProgress.set(0.3);
180-
181-
setTimeout(function() {
182-
assert.operator(NProgress.status, '==', 0.3);
183-
done();
184-
}, 500);
185-
});
186-
187175
it('should be able to pause and unpause existing nprogress', function(done) {
188-
this.timeout(2000)
176+
this.timeout(2000);
189177
NProgress.continue();
190178
NProgress.start();
191179
NProgress.set(0.3);
@@ -207,6 +195,18 @@
207195
done();
208196
}, 700);
209197
});
198+
199+
it('should not be a persitent operation', function(done) {
200+
this.timeout(600);
201+
NProgress.pause();
202+
NProgress.set(0);
203+
NProgress.start(); // <--- this should be unpaused progress bar
204+
205+
setTimeout(function() {
206+
assert.operator(NProgress.status, '>', NProgress.settings.minimum);
207+
done();
208+
}, 300);
209+
});
210210
});
211211
});
212212

0 commit comments

Comments
 (0)