Prevents refs/stash from being deleted

tiennou · tiennou · commit 1aa7aaea8913 · 2015-02-13T22:32:18.000+01:00
Fixes #299
diff --git a/Classes/Views/PBRefMenuItem.m b/Classes/Views/PBRefMenuItem.m
@@ -171,11 +171,12 @@ + (NSArray *) defaultMenuItemsForRef:(PBGitRef *)ref inRepository:(PBGitReposito
 	// delete ref
 	[items addObject:[PBRefMenuItem separatorItem]];
 	{
+		BOOL isStash = [[ref ref] hasPrefix:@"refs/stash"];
 		NSString *deleteTitle = [NSString stringWithFormat:@"Delete %@…", targetRefName];
 		if ([ref isRemote]) {
 			deleteTitle = [NSString stringWithFormat:@"Remove %@…", targetRefName];
 		}
-		BOOL deleteEnabled = !(isDetachedHead || isHead);
+		BOOL deleteEnabled = !(isDetachedHead || isHead || isStash);
 		PBRefMenuItem *deleteItem = [PBRefMenuItem itemWithTitle:deleteTitle action:@selector(showDeleteRefSheet:) enabled:deleteEnabled];
 		[items addObject:deleteItem];
 	}

Original file line number	Diff line number	Diff line change
`@@ -171,11 +171,12 @@ + (NSArray ) defaultMenuItemsForRef:(PBGitRef )ref inRepository:(PBGitReposito`
`171`	`171`	`// delete ref`
`172`	`172`	`[items addObject:[PBRefMenuItem separatorItem]];`
`173`	`173`	`{`
	`174`	`+ BOOL isStash = [[ref ref] hasPrefix:@"refs/stash"];`
`174`	`175`	`NSString *deleteTitle = [NSString stringWithFormat:@"Delete %@…", targetRefName];`
`175`	`176`	`if ([ref isRemote]) {`
`176`	`177`	`deleteTitle = [NSString stringWithFormat:@"Remove %@…", targetRefName];`
`177`	`178`	`}`
`178`		`- BOOL deleteEnabled = !(isDetachedHead \|\| isHead);`
	`179`	`+ BOOL deleteEnabled = !(isDetachedHead \|\| isHead \|\| isStash);`
`179`	`180`	`PBRefMenuItem *deleteItem = [PBRefMenuItem itemWithTitle:deleteTitle action:@selector(showDeleteRefSheet:) enabled:deleteEnabled];`
`180`	`181`	`[items addObject:deleteItem];`
`181`	`182`	`}`