Skip to content

Commit 6de1351

Browse files
Merge branch 'dev' into dspielman/update/boost_plugin_loader_0_4_2
2 parents 1f4b496 + 90f08d9 commit 6de1351

32 files changed

+1552
-978
lines changed

noether_gui/CMakeLists.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,13 @@ add_library(
6969
src/widgets/tool_path_modifiers/uniform_spacing_spline_modifier_widget.cpp
7070
src/widgets/tool_path_modifiers/uniform_spacing_linear_modifier_widget.cpp
7171
# Mesh Modifiers
72-
src/widgets/mesh_modifiers/cylinder_projection_modifier_widget.cpp
7372
src/widgets/mesh_modifiers/euclidean_clustering_modifier_widget.cpp
7473
src/widgets/mesh_modifiers/fill_holes_modifier_widget.cpp
7574
src/widgets/mesh_modifiers/normal_estimation_pcl_widget.cpp
7675
src/widgets/mesh_modifiers/normals_from_mesh_faces_modifier_widget.cpp
77-
src/widgets/mesh_modifiers/plane_projection_modifier_widget.cpp
76+
src/widgets/mesh_modifiers/ransac_primitive_fit_modifier_widget.cpp
77+
src/widgets/mesh_modifiers/ransac_cylinder_fit_modifier_widget.cpp
78+
src/widgets/mesh_modifiers/ransac_plane_fit_modifier_widget.cpp
7879
# Resources
7980
resources/resource.qrc
8081
)

noether_gui/include/noether_gui/widgets/mesh_modifiers/plane_projection_modifier_widget.h

Lines changed: 0 additions & 28 deletions
This file was deleted.
Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
#pragma once
2+
3+
#include <noether_gui/widgets/mesh_modifiers/ransac_primitive_fit_modifier_widget.h>
4+
5+
class QSpinBox;
6+
class QCheckBox;
7+
8+
namespace Ui
9+
{
10+
class RansacCylinderProjection;
11+
class Vector3dEditor;
12+
} // namespace Ui
13+
14+
namespace noether
15+
{
16+
class RansacCylinderProjectionMeshModifierWidget : public RansacPrimitiveFitMeshModifierWidget
17+
{
18+
public:
19+
RansacCylinderProjectionMeshModifierWidget(QWidget* parent = nullptr);
20+
21+
void configure(const YAML::Node& config) override;
22+
void save(YAML::Node& config) const override;
23+
24+
protected:
25+
Ui::RansacCylinderProjection* model_ui_;
26+
Ui::Vector3dEditor* axis_;
27+
};
28+
29+
class RansacCylinderFitMeshModifierWidget : public RansacCylinderProjectionMeshModifierWidget
30+
{
31+
public:
32+
RansacCylinderFitMeshModifierWidget(QWidget* parent);
33+
34+
void configure(const YAML::Node& config) override;
35+
void save(YAML::Node& config) const override;
36+
37+
protected:
38+
QSpinBox* resolution_;
39+
QCheckBox* include_caps_;
40+
};
41+
42+
} // namespace noether
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
#pragma once
2+
3+
#include <noether_gui/widgets/mesh_modifiers/ransac_primitive_fit_modifier_widget.h>
4+
5+
namespace noether
6+
{
7+
/**
8+
* @ingroup gui_widgets_mesh_modifiers
9+
*/
10+
class RansacPlaneProjectionMeshModifierWidget : public RansacPrimitiveFitMeshModifierWidget
11+
{
12+
public:
13+
using RansacPrimitiveFitMeshModifierWidget::RansacPrimitiveFitMeshModifierWidget;
14+
15+
void save(YAML::Node&) const override;
16+
};
17+
18+
} // namespace noether
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,22 @@
44

55
namespace Ui
66
{
7-
class CylinderSegmentation;
7+
class RansacPrimitiveFit;
88
class Vector3dEditor;
99
} // namespace Ui
1010

1111
namespace noether
1212
{
13-
class CylinderProjectionModifierWidget : public BaseWidget
13+
class RansacPrimitiveFitMeshModifierWidget : public BaseWidget
1414
{
1515
public:
16-
CylinderProjectionModifierWidget(QWidget* parent = nullptr);
16+
RansacPrimitiveFitMeshModifierWidget(QWidget* parent = nullptr);
1717

1818
void configure(const YAML::Node& config) override;
1919
void save(YAML::Node& config) const override;
2020

2121
protected:
22-
Ui::CylinderSegmentation* ui_;
22+
Ui::RansacPrimitiveFit* ui_;
2323
Ui::Vector3dEditor* axis_;
2424
};
2525

noether_gui/src/plugins.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@
3232
#include <noether_gui/widgets/tool_path_modifiers/uniform_spacing_spline_modifier_widget.h>
3333
#include <noether_gui/widgets/tool_path_modifiers/uniform_spacing_linear_modifier_widget.h>
3434
// Mesh Modifiers
35-
#include <noether_gui/widgets/mesh_modifiers/cylinder_projection_modifier_widget.h>
36-
#include <noether_gui/widgets/mesh_modifiers/plane_projection_modifier_widget.h>
3735
#include <noether_gui/widgets/mesh_modifiers/euclidean_clustering_modifier_widget.h>
36+
#include <noether_gui/widgets/mesh_modifiers/fill_holes_modifier_widget.h>
3837
#include <noether_gui/widgets/mesh_modifiers/normal_estimation_pcl_widget.h>
3938
#include <noether_gui/widgets/mesh_modifiers/normals_from_mesh_faces_modifier_widget.h>
40-
#include <noether_gui/widgets/mesh_modifiers/fill_holes_modifier_widget.h>
39+
#include <noether_gui/widgets/mesh_modifiers/ransac_cylinder_fit_modifier_widget.h>
40+
#include <noether_gui/widgets/mesh_modifiers/ransac_plane_fit_modifier_widget.h>
4141

4242
#include <QWidget>
4343
#include <QMessageBox>
@@ -46,13 +46,14 @@
4646
namespace noether
4747
{
4848
// Mesh Modifiers
49-
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(CylinderProjectionModifierWidget, CylinderSegmentation)
5049
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(EuclideanClusteringMeshModifierWidget, EuclideanClustering)
5150
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(FillHolesModifierWidget, FillHoles)
5251
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(NormalEstimationPCLMeshModifierWidget, NormalEstimationPCL)
5352
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(NormalsFromMeshFacesMeshModifierWidget, NormalsFromMeshFaces)
53+
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(RansacCylinderFitMeshModifierWidget, RansacCylinderFit)
54+
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(RansacCylinderProjectionMeshModifierWidget, RansacCylinderProjection)
5455
//! [GUI Plugin Alias Correspondence]
55-
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(PlaneProjectionMeshModifierWidget, PlaneProjection)
56+
EXPORT_SIMPLE_MESH_MODIFIER_WIDGET_PLUGIN(RansacPlaneProjectionMeshModifierWidget, RansacPlaneProjection)
5657
//! [GUI Plugin Alias Correspondence]
5758

5859
// Direction Generators

noether_gui/src/widgets/mesh_modifiers/cylinder_projection_modifier_widget.cpp

Lines changed: 0 additions & 60 deletions
This file was deleted.

0 commit comments

Comments
 (0)