-
Notifications
You must be signed in to change notification settings - Fork 353
[Diagnostics] Add diagnostics of execution time and periodicity of the hardware components #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Diagnostics] Add diagnostics of execution time and periodicity of the hardware components #2086
Conversation
…ferent frequencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, and tested with the demos. Thanks!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2086 +/- ##
==========================================
- Coverage 89.12% 88.90% -0.23%
==========================================
Files 139 140 +1
Lines 16117 16410 +293
Branches 1389 1430 +41
==========================================
+ Hits 14364 14589 +225
- Misses 1224 1267 +43
- Partials 529 554 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this successfully on my robot today. It gave me strange results, but it was the first time that I was able to introspect this ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This PR aims to add diagnostics to the hardware components regarding their periodicity and execution time.
This PR also publishes the periodicity of controller and HW components that run at different rate
This PR also adds new tests for the asynchronous hardware components that were pending in #2076
Tested (#2005) on the real hardware and it seems to work as expected
The diagnostics should kinda look like the following screenshots (The following are only to look at the summary):