Add a custom plugin for simulating actuator dynamics to the demos #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
force-pushed
the
add/custom_plugin
branch
from
335b5a5 to
d2b0ec2
Compare
ahcorde
requested changes
Sep 29, 2025
| @@ -0,0 +1,84 @@ | |||
| // Copyright 2021 Open Source Robotics Foundation, Inc. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 Open Source Robotics Foundation, Inc. | |
| // Copyright 2025 Open Source Robotics Foundation, Inc. |
Comment on lines
+25
to
+26
| #include "rclcpp_lifecycle/state.hpp" | ||
| #include "rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "rclcpp_lifecycle/state.hpp" | |
| #include "rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp" | |
| #include <rclcpp_lifecycle/state.hpp> | |
| #include <rclcpp_lifecycle/node_interfaces/lifecycle_node_interface.hpp> |
Member
Author
There was a problem hiding this comment.
in the other repos we use the google codestyle which says:
Headers should only be included using an angle-bracketed path if the library requires you to do so.
as you prefer..
| @@ -0,0 +1,118 @@ | |||
| # Copyright 2021 Open Source Robotics Foundation, Inc. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| # Copyright 2021 Open Source Robotics Foundation, Inc. | |
| # Copyright 2025 Open Source Robotics Foundation, Inc. |
gz_ros2_control_demos/launch/cart_example_velocity_custom_plugin.launch.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,402 @@ | |||
| // Copyright 2021 Open Source Robotics Foundation, Inc. | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 Open Source Robotics Foundation, Inc. | |
| // Copyright 2025 Open Source Robotics Foundation, Inc. |
| #include <gz/sim/components/Name.hh> | ||
| #include <gz/sim/components/ParentEntity.hh> | ||
|
|
||
| #include "control_toolbox/low_pass_filter.hpp" |
Collaborator
There was a problem hiding this comment.
Suggested change
| #include "control_toolbox/low_pass_filter.hpp" | |
| #include <control_toolbox/low_pass_filter.hpp> |
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
ahcorde
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on top of #688