Commit 24321af
committed
[tmva][sofie] Remove the graph_nets-based GNN support
The SOFIE GNN classes could only be filled by parsing models built with
DeepMind graph_nets and dm-sonnet, whose last releases date from 2020:
they cannot be installed together with current Python and TensorFlow
versions anymore (the corresponding Python test had already silently
disappeared from CI, since it is gated on the availability of those
modules), and the parser relied on private implementation details of
both packages.
Equivalent graph-network models defined with PyTorch can be deployed
through the SOFIE ONNX parser, whose operator support covers the
graph-network building blocks; the migrated TMVA_SOFIE_GNN tutorials
demonstrate that workflow and produce inference results identical to
this implementation.
Removed:
- RModel_GNN, RModel_GraphIndependent and the RFunction classes
(RFunction_MLP, RFunction_Sum, RFunction_Mean), together with their
GNN_Init/GraphIndependent_Init input structs and the EmitGNN /
EmitGraphIndependent tests
- the GNN parts of RModel_Base (Options::kGNN / kGNNComponent, the
GraphType/FunctionTarget/FunctionReducer/FunctionRelation enums and
the RModel_GNNBase class) and the corresponding code paths and the
weight-file read position in RModel::Generate
- the GNN_Data struct with its Copy/Concatenate helpers in SOFIE_common
and its emission in the generated-code helpers
- the ParseFromMemory Python interface (_gnn.py pythonization) and its
test
- the dm-sonnet and graph_nets entries in requirements.txt
🤖 Done with the help of AI1 parent 692a1ed commit 24321af
31 files changed
Lines changed: 25 additions & 2211 deletions
File tree
- README/ReleaseNotes/v642
- bindings/pyroot/pythonizations
- python
- ROOT/_pythonization/_tmva
- test
- tmva
- sofie
- inc
- TMVA
- src
- test
- GNN
- tmva/inc/TMVA
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
65 | 69 | | |
66 | 70 | | |
67 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
58 | 58 | | |
59 | 59 | | |
60 | 60 | | |
61 | | - | |
62 | | - | |
| 61 | + | |
63 | 62 | | |
64 | 63 | | |
65 | 64 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
14 | | - | |
| 14 | + | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
Lines changed: 0 additions & 351 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | 111 | | |
121 | 112 | | |
122 | 113 | | |
| |||
0 commit comments