Xcode 10 seems to brake the plugin completely

[gklka]

Has anyone luck with Xcode 10?

[basvankuijck]

No, no luck whatsoever. usigning Xcode and adding the uuid in the plugin worked on Xcode9.
But Xcode10 (the GM at least) is not working as I was hoping it would.

[sunnyyoung]

Yes, the same issue here, with unsigned Xcode 10 Release version. 💔

[tanranran]

me too Xcode Version 10.0 (10A255)

[absolutlabs]

actually it's still working in the Report navigator > debug session , but less useful than directly in the console :/

[sbwilson]

I wonder whether the console view's base class has changed. I spent a little time playing with this tonight, and can't get the new console to trigger the method [NSTextStorage fixAttributesInRange:]. From digging through the class-dump'ed source for a variety of the frameworks. The most obvious (found in IDEKit.framework) is this:

IDEConsoleTextView * consoleTextView = [[[[[[[NSApplication sharedApplication] _workspaceWindowControllers] firstObject] editorArea] valueForKey: @"_activeDebuggerArea"] consoleArea] valueForKey: @"_consoleView"]

I've played a little with setting breakpoints and trying to inject the xc_fixAttributesInRange: method into this class, and neither seems to have any success. Further, printing the contents of this view suggests it's empty.

There's a second ivar of the consoleArea (of type IDEConsoleArea), _consoleViewSwift, which returns a Swift class IDEConsoleEditorView (found in PlugIns/IDESourceEditor.framework). Printing the -string method of this class into the console gives the correct output. It's full path is given as:

[[[[[[[[NSApplication sharedApplication] _workspaceWindowControllers] firstObject] editorArea] valueForKey: @"_activeDebuggerArea"] valueForKey: @"_rightReplacementView"] valueForKey: @"_installedViewController"] valueForKey: @"_consoleViewSwift"]

And we can confirm that this the new console view:

po [[[[[[[[[[[NSApplication sharedApplication] _workspaceWindowControllers] firstObject] editorArea] valueForKey: @"_activeDebuggerArea"] valueForKey: @"_rightReplacementView"] subviews] firstObject] subviews] firstObject] subviews]
<__NSArrayM 0x608001049e40>(
<DVTScopeBarView: 0x12410adf0>,
IDEConsoleEditorView: Frame: (0.0, 28.0, 967.0, 389.0), Bounds: (0.0, 0.0, 967.0, 389.0) contentViewOffset: 0.0
)

So I suspect this is the starting point for the Xcode 10 version of this implementation. My attempts to go any further here are hampered by my lack of Swift experience, such as an inability to access the ivars of the IDESourceEditorView. I'll keep hacking tonight, but I don't suspect I'll get much further...

Edit:
It may actually be worth looking at the swift class SourceEditorLineLayer inside SourceEditor.framework. It's a CALayer-based class, and it looks like the -contents of these are CGImages. I suspect the -renderInContext: method generates these images, so maybe swizzling this method could be ticket to a solution?

[basvankuijck]

Can someone confirm that other plugins still work and it's just this one.
Or that Apple has actually closed the door completely on xcplugin.

[gklka]

I think they work fine (including this one), only the console has been changed, and XcodeColors cannot patch it the old way.

[absolutlabs]

yep, exactly

[sbwilson]

I think they work fine (including this one), only the console has been changed, and XcodeColors cannot patch it the old way.

Except it also looks like the editor view has been rewritten in Swift as well — perusing the view hierarchy shows that there's now a IDESourceEditor.SourceCodeEditorContainerView_ControlledBy_IDESourceEditor.SourceCodeEditor view, which could mean that many other plugins are likely to be affected...

[basvankuijck]

I made a dump of the view hierarchy of Xcode10: https://gist.github.com/basvankuijck/32693fd517c641f94c13295344f9620e

[sbwilson]

I've had a little more of a dig, now that I have figured out how to set breakpoints on these system Swift classes (b SourceEditor.SourceEditorLineLayer.init was my first success)...

The line layers are created by SourceEditorLayoutManager.makeLineLayerForLine(..). Early in the disassembly, it calls SourceEditor.SourceEditorLayoutManager.attributedStringAndImagesForLine(..).
If we were able to swizzle this method, first calling the original method, followed by most of the meat from ApplyANSIColors(), would we get back our beloved colours?

[sbwilson]

Some further exploration. My class-dump'ed version of SourceEditor doesn't include any methods inside the SourceEditorLayoutManager class — though I'd wager that it may be due to the fact that this method returns a tuple instead of a single value, and hence class-dump can't interpret it properly. But I can find the IMP for this method:

(lldb) b SourceEditor.SourceEditorLayoutManager.attributedStringAndImagesForLine
Breakpoint 2: where = SourceEditor`SourceEditor.SourceEditorLayoutManager.attributedStringAndImagesForLine(_: Swift.Int, context: SourceEditor.SourceEditorTextAttributeContext) -> (__C.NSAttributedString, Swift.Array<(image: __C.CGImageRef, columnRange: Swift.Range<Swift.Int>)>), address = 0x0000000119a94f70

That address can be cast to an IMP and displayed:

(lldb) po (IMP)0x0000000119a94f70
(SourceEditor`SourceEditor.SourceEditorLayoutManager.attributedStringAndImagesForLine(_: Swift.Int, context: SourceEditor.SourceEditorTextAttributeContext) -> (__C.NSAttributedString, Swift.Array<(image: __C.CGImageRef, columnRange: Swift.Range<Swift.Int>)>))

I'm not certain we can necessarily work backwards from here though, nor how to go about swizzling this method. So I think I'll pause here, remove my XcodeColor bits from my current logger for now, and hopefully somebody Swiftier than I will be able to take this from here...

[basvankuijck]

For those concerning, here is a class dump of SourceEditor for Xcode10: https://github.com/basvankuijck/Xcode-headers/tree/master/SourceEditor

[mooch443]

I'm afraid I can't offer much help with this (other than emotional support), but I don't want to live without my colors... It's so puzzling that they wouldn't just add this as a feature. Seems like I need to learn Swift after all? Please do tell if anyone solves this first.

[sedwo]

@sbwilson @basvankuijck Your investigations in trying to get plugins working is very hopeful. I (and perhaps others) might even be inclined to support your efforts by tipping a patreon account. As this type of visual logging is still far superior then anything Apple has delivered.
I'd say keep up the great work to revive Xcode plugins!