From bcd63085abd971e5f7358ca6067388ee965db647 Mon Sep 17 00:00:00 2001 From: Robert Mosolgo Date: Tue, 24 Jun 2025 14:52:46 -0400 Subject: [PATCH] Remove useless job counting --- lib/graphql/execution/interpreter/runtime.rb | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/lib/graphql/execution/interpreter/runtime.rb b/lib/graphql/execution/interpreter/runtime.rb index d055186ed6..a2d0f389f5 100644 --- a/lib/graphql/execution/interpreter/runtime.rb +++ b/lib/graphql/execution/interpreter/runtime.rb @@ -298,8 +298,6 @@ def evaluate_selections(gathered_selections, selections_result, target_result, r end call_method_on_directives(:resolve, selections_result.graphql_application_value, directives) do - finished_jobs = 0 - enqueued_jobs = gathered_selections.size gathered_selections.each do |result_name, field_ast_nodes_or_ast_node| # Field resolution may pause the fiber, # so it wouldn't get to the `Resolve` call that happens below. @@ -310,12 +308,6 @@ def evaluate_selections(gathered_selections, selections_result, target_result, r evaluate_selection( result_name, field_ast_nodes_or_ast_node, selections_result ) - finished_jobs += 1 - if finished_jobs == enqueued_jobs - if target_result - selections_result.merge_into(target_result) - end - end @dataloader.clear_cache } else @@ -323,15 +315,12 @@ def evaluate_selections(gathered_selections, selections_result, target_result, r evaluate_selection( result_name, field_ast_nodes_or_ast_node, selections_result ) - finished_jobs += 1 - if finished_jobs == enqueued_jobs - if target_result - selections_result.merge_into(target_result) - end - end } end end + if target_result + selections_result.merge_into(target_result) + end selections_result end end