Update dev setup to support modern JS syntax (visgl#5517)

Author: Pessimistress

.eslintrc.js

@@ -22,13 +22,15 @@ module.exports = {
   rules: {
     'guard-for-in': 0,
     'no-inline-comments': 0,
+    // eslint treats optional chaining as unused expressions
+    'no-unused-expressions': 0,
     camelcase: 0,
     'react/forbid-prop-types': 0,
     'react/no-deprecated': 0,
     'import/no-unresolved': ['error', {ignore: ['test']}],
     'import/no-extraneous-dependencies': ['error', {devDependencies: false, peerDependencies: true}]
   },
   parserOptions: {
-    ecmaVersion: 2018
+    ecmaVersion: 2020
   }
 };

.github/workflows/test.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: '12.x'
+          node-version: '14.x'
 
       - name: Install dependencies
         run: |

.github/workflows/website.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Use Node.js
         uses: actions/setup-node@v1
         with:
-          node-version: '12.x'
+          node-version: '14.x'
 
       - name: Get version
         id: get-version

CONTRIBUTING.md

@@ -9,7 +9,7 @@ PRs and bug reports are welcome, and we are actively looking for new maintainers
 
 The **master** branch is the active development branch.
 
-Building deck.gl locally from the source requires node.js `>=10`. Further limitations on the Node version may be imposed by [puppeteer](https://github.com/puppeteer/puppeteer#usage) and [headless-gl](https://github.com/stackgl/headless-gl#supported-platforms-and-nodejs-versions).
+Building deck.gl locally from the source requires node.js `>=14`. Further limitations on the Node version may be imposed by [puppeteer](https://github.com/puppeteer/puppeteer#usage) and [headless-gl](https://github.com/stackgl/headless-gl#supported-platforms-and-nodejs-versions).
 We use [yarn](https://yarnpkg.com/en/docs/install) to manage the dependencies of deck.gl.
 
 ```bash

modules/jupyter-widget/src/playground/create-deck.js

@@ -2,7 +2,8 @@
 /* eslint-disable no-console */
 import {CSVLoader} from '@loaders.gl/csv';
 import {registerLoaders} from '@loaders.gl/core';
-import GL from '@luma.gl/constants';
+// Avoid calling it GL - would be removed by babel-plugin-inline-webgl-constants
+import GLConstants from '@luma.gl/constants';
 
 import makeTooltip from './widget-tooltip';
 
@@ -30,7 +31,7 @@ const jsonConverterConfiguration = {
   // Will be resolved as `<enum-name>.<enum-value>`
   enumerations: {
     COORDINATE_SYSTEM: deck.COORDINATE_SYSTEM,
-    GL
+    GL: GLConstants
   }
 };
 

package.json

@@ -16,6 +16,9 @@
   "workspaces": [
     "modules/*"
   ],
+  "resolutions": {
+    "acorn": "7.4.1"
+  },
   "scripts": {
     "bootstrap": "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true yarn && ocular-bootstrap",
     "clean": "ocular-clean",
@@ -41,6 +44,7 @@
     "jsdom": false
   },
   "devDependencies": {
+    "@babel/register": "^7.13.0",
     "@loaders.gl/csv": "^2.3.9",
     "@loaders.gl/polyfills": "^2.3.9",
     "@luma.gl/test-utils": "^8.4.1",
@@ -67,11 +71,13 @@
     "react": "^16.2.0",
     "react-dom": "^16.2.0",
     "react-map-gl": "^5.1.0",
-    "reify": "^0.18.1",
     "s2-geometry": "^1.2.10"
   },
   "pre-commit": [
     "test-fast",
     "bindings-precommit-tests"
-  ]
+  ],
+  "engines": {
+    "node": ">=14"
+  }
 }

test/bench/layer.bench.js

@@ -126,6 +126,7 @@ export default function layerBench(suite) {
     .add('calculate instance picking colors', () => {
       const numInstances = 1e6;
       const target = new Uint8ClampedArray(numInstances * 3);
+      testLayer.internalState = {};
       testLayer.calculateInstancePickingColors({value: target, size: 3}, {numInstances});
     });
 }

test/bench/node.js

@@ -1,3 +1,12 @@
-require('reify');
+require('@babel/register')({
+  presets: [
+    [
+      '@babel/env',
+      {
+        targets: {node: '14'}
+      }
+    ]
+  ]
+});
 
 require('./index');

test/modules/google-maps/mock-maps-api.js

@@ -143,12 +143,8 @@ export class OverlayView {
   }
 
   setMap(map) {
-    if (this.map) {
-      this.map._removeOverlay(this);
-    }
-    if (map) {
-      map._addOverlay(this);
-    }
+    this.map?._removeOverlay(this);
+    map?._addOverlay(this);
     this.map = map;
   }
 

test/modules/json/json-configuration-for-deck.js

@@ -1,5 +1,5 @@
 import {COORDINATE_SYSTEM, MapView, FirstPersonView, MapController} from '@deck.gl/core';
-import GL from '@luma.gl/constants';
+import GLConstants from '@luma.gl/constants';
 
 export const log = console; // eslint-disable-line
 
@@ -17,7 +17,7 @@ export default {
   // Will be resolved as `<enum-name>.<enum-value>`
   enumerations: {
     COORDINATE_SYSTEM,
-    GL
+    GL: GLConstants
   },
   constants: {
     MapController