5.3.0: Array items perform much worse

[MatinF]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.0.0-beta.18 vs. 5.0.0-beta.19

Current Behavior

We wanted to test out the latest update to rjsf (upgrading from 5.0.0 beta11 to 5.3.0) in order to benefit from the new ability to 'copy' array items, which was added as a feature in the latest release.

Unfortunately, the performance of the updated version is much worse when it comes to adding/removing array items - to an extent where it now takes ~1-2 seconds to add a new entry, up from <0.1 seconds in the previous release. After isolating the release introducing this, it seems to start after 5.0.0-beta.18.

I am unable to replicate this in the live playground, though I am unsure why.

Expected Behavior

I would expect the performance to be similar to previous versions.

Steps To Reproduce

1. Use a standard rjsf setup with 5.0.0-beta.18 vs. 5.0.0-beta.19

2. Use below custom array template:

3. To replicate this, test with the below formdata (config) and schema/uischema. The slow performance can be seen by going to CAN CH1 and adding entries in the Transmit list section.
   json-schema.zip

[nickgros]

@MatinF I tried to re-create this in CodeSandbox and didn't notice issues with array performance https://codesandbox.io/s/rjsf-3517-repro-679s2u

Can you create your own example or modify the above so we can get to the bottom of this (or clarify further how to see the issue if it is present in that example)?

[MatinF]

I've been trying to replicate your dependency setup in my own application, but struggling to achieve this due to some legacy dependencies. I recognize that there is not a performance issue in your sandbox, so I am not sure why there is on my side.

The app I'm testing this with is below:
https://github.com/CSS-Electronics/config-editor-base

You can install it by running npm install in the root and in the example/ folder, followed by running npm start in both folders. If you then load attached configuration file you'll be able to load up the editor:
config-01.07.zip

I'm guessing the issue is related to some of the outdated dependencies I have, such as React 16.0.0 and other things. I tried various steps such as updating from validator v6 to v8 as in your sandbox, but the slow performance persists.

As you can see if you decide to install the app, the performance is snappy with the default version of rjsf in the repository - but if you update to 5.3.0 it becomes much slower.

[heath-freenome]

@MatinF Wow that a lot of code you've written. I don't really have time to analyze and inspect it all to find the issue for you. I'm wondering if you are experiencing an interaction in your own code with react rerendering? Have you been able to debug into the RJSF code to see if it is there? Also, I just fixed an issue in 5.5.1 that prevented infinite recursions when using a schema with recursive refs. Can you check to see if that helped.