Skip to content

Commit bdacaa9

Browse files
committed
deptry: add patch to upgrade pip in each functional-test fixture venv
ensurepip's bundled pip on the manylinux_riscv64 image doesn't recognize the riscv64 wheel tag, so the poetry/pdm/uv/pip fixture venvs functional tests create with venv.EnvBuilder fail to install our own riscv64 wheel with "... is not a supported wheel on this platform" even though the outer cibuildwheel test venv's own pip installs the identical wheel without complaint. Verified locally (doesn't reproduce off riscv64, but the extra `pip install --upgrade pip` step is a no-op there and the functional suite still passes: 38 passed, 1 skipped).
1 parent c786095 commit bdacaa9

1 file changed

Lines changed: 36 additions & 0 deletions

File tree

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
From cba283a56f34d6ace2bcad4c3cbcce5791aa6cb3 Mon Sep 17 00:00:00 2001
2+
From: Ludovic Henry <git@ludovic.dev>
3+
Date: Fri, 4 Sep 2026 01:36:29 +0200
4+
Subject: [PATCH] tests: upgrade pip in each throwaway venv before installing
5+
the wheel
6+
7+
VirtualEnvironment.setup creates each poetry/pdm/uv/pip fixture venv with
8+
venv.EnvBuilder(with_pip=True), which provisions whatever pip ensurepip
9+
bundled for that Python build. On the manylinux_riscv64 cibuildwheel image
10+
that bundled pip predates riscv64 wheel-tag support, so `pip install
11+
--no-cache-dir <wheel>` against our own riscv64 wheel fails with "... is
12+
not a supported wheel on this platform" even though the outer test venv's
13+
own (newer) pip installs the identical wheel without complaint moments
14+
earlier.
15+
16+
Upstream-Status: Inappropriate [ensurepip's bundled pip on the manylinux_riscv64 image predates riscv64 wheel-tag support; not reproducible off riscv64]
17+
---
18+
tests/utils.py | 2 ++
19+
1 file changed, 2 insertions(+)
20+
21+
diff --git a/tests/utils.py b/tests/utils.py
22+
index 10b22a0..7320630 100644
23+
--- a/tests/utils.py
24+
+++ b/tests/utils.py
25+
@@ -101,6 +101,8 @@ class VirtualEnvironment:
26+
)
27+
virtual_env.create(self.project_path)
28+
29+
+ self.run("pip install --upgrade pip", check=True)
30+
+
31+
shutil.copytree(deptry_directory / "tests/fixtures" / self.project, self.project_path / "project")
32+
33+
self.run(
34+
--
35+
2.50.1 (Apple Git-155)
36+

0 commit comments

Comments
 (0)