PR gets merged before all workflows were successful

[DanielBadura]

How would you describe the issue?

First, im not sure if this is a real bug here or something wrong with the config or gh workflow fail, maybe you can help me?

I recently added the workflow for auto-merges here: https://github.com/maglnet/ComposerRequireChecker/blob/3.6.x/.github/workflows/merge-dependabot-upgrades.yml
I wanted that these workflows listed there should all be successfully run and then the PR from dependatbot should be auto-merged.

Here one PR that was merged to fast: maglnet/ComposerRequireChecker#323

What are the expected results?

I would expect that all jobs need to be successful for the auto-merge.

What are the actual results?

The merge happens before all job were green.

How much does it hurt?

The solution would be to put all workflow files into one "Continues Integration" which is really not nice for maintainance. For example here: https://github.com/Roave/BetterReflection/tree/5.0.x/.github/workflows

[rbubley]

This was discussed (but no solution) here: https://stackoverflow.com/questions/67721399/run-a-workflow-when-multiple-other-workflows-have-finished-in-github-actions.

This looks like a promising approach, but have not tested: https://github.com/marketplace/actions/wait-on-check

[dunyakirkali]

Isn't it because dependabot has been added as an admin, and the repo is set to not include administrators in the merge check that it gets merged?

or is this something else?

[aaneitchik]

@dunyakirkali I tried looking into this, and I believe @rbubley is right: the problem here is that in the example that @DanielBadura shared

on:
  workflow_run:
    types:
      - completed
    workflows:
      - "Check Coding Standards"
      - "Static Analysis by PHPStan"
      - "Static Analysis by Psalm"
      - "Static Analysis by Require-Checker"
      - "PHPUnit tests"

there are multiple workflows, and looking at the GitHub docs, in particular

If you specify multiple workflows for the workflow_run event, only one of the workflows needs to run. For example, a workflow with the following trigger will run whenever the "Staging" workflow or the "Lab" workflow completes.

on:
workflow_run:
  workflows: [Staging, Lab]
 types:
   - completed

so as soon as one of the workflow finishes, this will be true: github.event.workflow_run.conclusion == 'success' and our action will run. I may be missing something, but unfortunately I'm afraid going with a single workflow is the only way to make the action work

[DanielBadura]

Maybe this should then be documented here since it can be misleading right now.