Skip to content

Conversation

@empovit
Copy link
Member

@empovit empovit commented May 14, 2025

  • Profiling metrics DCGM_FI_PROF_* aren't available on pre-Volta GPUs
  • Consolidate the default metrics into the configmap so that installing the console plugin doesn't break other tools

@openshift-ci openshift-ci bot requested review from mareklibra and rawagner May 14, 2025 11:10
@openshift-ci
Copy link

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: empovit
Once this PR has been reviewed and has the lgtm label, please assign mareklibra for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@empovit
Copy link
Member Author

empovit commented May 14, 2025

/cc @mresvanis

@openshift-ci openshift-ci bot requested a review from mresvanis May 14, 2025 11:16
* Profiling metrics DCGM_FI_PROF_* aren't available on pre-Volta GPUs
* Consolidate the default metrics into the configmap so that
  installing the console plugin doesn't break other tools
@empovit empovit force-pushed the remove-profiling-metrics branch from bf6a37a to 63e6e44 Compare May 14, 2025 11:17
*/

/* Used metrics
DCGM_FI_PROF_GR_ENGINE_ACTIVE, gauge, gpu utilization.
Copy link
Member

@mresvanis mresvanis May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

II{U,R}C we chose DCGM_FI_PROF_GR_ENGINE_ACTIVE because it is available also when using MIG, while DCGM_FI_DEV_GPU_UTIL is not.

If we would like to drop MIG support for other NVIDIA GPU models, then no objection from my part (whatever makes more sense business-wise).

@empovit
Copy link
Member Author

empovit commented May 14, 2025

/hold until we test the changes with MIG-supported GPUs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants