fix: have caddy apply url prefix to relative redirects from services #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess I need to limit git commit titles to 70 characters. oops. |
Docteh
changed the title
Definitely required for autumn, as an example /autumn/attachments/:id: will redirect to /attachments/:id:/:filename: But since we are self-hosting, the requester (client) actually needs to be redirected to /autumn/attachments/:id:/:filename: Speculatively added for the other services Signed-off-by: Kyle Kienapfel <[email protected]>
Docteh
changed the title
|
Tweaked the commit message so that the title is now under 70 characters fix: have caddy apply url prefix to relative redirects from services Definitely required for autumn, as an example /autumn/attachments/:id: will redirect to /attachments/:id:/:filename: Speculatively added for the other services |
insertish
approved these changes
Jul 18, 2025
github-project-automation
bot
moved this from 🆕 Untriaged
to 💡 Ready to merge
in Pull Request Overview
github-project-automation
bot
moved this from 💡 Ready to merge
to ✅ Merged
in Pull Request Overview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g with /
Definitely required for autumn, as /autumn/attachments/:id: will redirect to /attachments/:id:/:filename: But we want the browser to redirect to /autumn/attachments/:id:/:filename:
Speculatively added for the other services
Please make sure to check the following tasks before opening and submitting a PR
fixes #137