Skip to content

ServerInviteDialog::handle_bye uses wrong TerminatedReason (UacBye instead of UasBye) #64

@FedorKiselev76

Description

@FedorKiselev76

In ServerInviteDialog::handle_bye() the dialog is terminated with
TerminatedReason::UacBye, but this code runs on the server/UAS side
handling an incoming BYE request.

async fn handle_bye(&mut self, tx: &mut Transaction) -> Result<()> {
    info!(id = %self.id(), "received bye {}", tx.original.uri);
    self.inner
        .transition(DialogState::Terminated(self.id(), TerminatedReason::UacBye))?;
    tx.reply(rsip::StatusCode::OK).await?;
    Ok(())
}


Proposed fix
self.inner.transition(
    DialogState::Terminated(self.id(), TerminatedReason::UasBye)
)?;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions