fix: update version to 0.2.32 and fix missing ack for client invite

Author: shenjinti

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rsipstack"
-version = "0.2.31"
+version = "0.2.32"
 edition = "2021"
 description = "SIP Stack Rust library for building SIP applications"
 license = "MIT"

src/dialog/client_dialog.rs

@@ -453,6 +453,23 @@ impl ClientInviteDialog {
             match msg {
                 SipMessage::Request(_) => {}
                 SipMessage::Response(resp) => {
+                    let branch = match tx
+                        .original
+                        .via_header()?
+                        .params()?
+                        .iter()
+                        .find(|p| matches!(p, rsip::Param::Branch(_)))
+                    {
+                        Some(p) => p.clone(),
+                        None => {
+                            info!(id=%self.id(),"no branch found in via header");
+                            return Err(crate::Error::DialogError(
+                                "no branch found in via header".to_string(),
+                                self.id(),
+                            ));
+                        }
+                    };
+
                     match resp.status_code {
                         StatusCode::Trying => {
                             self.inner.transition(DialogState::Trying(self.id()))?;
@@ -463,6 +480,21 @@ impl ClientInviteDialog {
                             continue;
                         }
                         StatusCode::ProxyAuthenticationRequired | StatusCode::Unauthorized => {
+                            let ack = self.inner.make_request(
+                                rsip::Method::Ack,
+                                resp.cseq_header()?.seq().ok(),
+                                None,
+                                Some(branch),
+                                None,
+                                None,
+                            )?;
+                            match tx.send_ack(ack).await {
+                                Ok(_) => {}
+                                Err(e) => {
+                                    warn!("send ack error: {}", e);
+                                }
+                            }
+
                             if auth_sent {
                                 final_response = Some(resp.clone());
                                 info!(id=%self.id(),"received {} response after auth sent", resp.status_code);
@@ -500,42 +532,22 @@ impl ClientInviteDialog {
                         None => {}
                     }
 
-                    // only send ACK if response is final (2xx)
-                    if matches!(resp.status_code, StatusCode::OK | StatusCode::Accepted) {
-                        let branch = match tx
-                            .original
-                            .via_header()?
-                            .params()?
-                            .iter()
-                            .find(|p| matches!(p, rsip::Param::Branch(_)))
-                        {
-                            Some(p) => p.clone(),
-                            None => {
-                                info!(id=%self.id(),"no branch found in via header");
-                                return Err(crate::Error::DialogError(
-                                    "no branch found in via header".to_string(),
-                                    self.id(),
-                                ));
-                            }
-                        };
-
-                        let ack = self.inner.make_request(
-                            rsip::Method::Ack,
-                            resp.cseq_header()?.seq().ok(),
-                            None,
-                            Some(branch),
-                            None,
-                            None,
-                        )?;
+                    let ack = self.inner.make_request(
+                        rsip::Method::Ack,
+                        resp.cseq_header()?.seq().ok(),
+                        None,
+                        Some(branch),
+                        None,
+                        None,
+                    )?;
 
-                        if let Ok(id) = DialogId::try_from(&ack) {
-                            dialog_id = id;
-                        }
-                        match tx.send_ack(ack).await {
-                            Ok(_) => {}
-                            Err(e) => {
-                                warn!("send ack error: {}", e);
-                            }
+                    if let Ok(id) = DialogId::try_from(&ack) {
+                        dialog_id = id;
+                    }
+                    match tx.send_ack(ack).await {
+                        Ok(_) => {}
+                        Err(e) => {
+                            warn!("send ack error: {}", e);
                         }
                     }
 

src/transaction/transaction.rs

@@ -313,13 +313,7 @@ impl Transaction {
                 _ => TransactionState::Proceeding,
             },
             _ => match self.transaction_type {
-                TransactionType::ServerInvite => {
-                    if response.status_code.kind() == rsip::StatusCodeKind::Successful {
-                        TransactionState::Completed
-                    } else {
-                        TransactionState::Terminated
-                    }
-                }
+                TransactionType::ServerInvite => TransactionState::Completed,
                 _ => TransactionState::Terminated,
             },
         };
@@ -551,13 +545,7 @@ impl Transaction {
             }
             _ => {
                 if self.transaction_type == TransactionType::ClientInvite {
-                    if self.original.method == rsip::Method::Invite
-                        && resp.status_code.kind() == rsip::StatusCodeKind::Successful
-                    {
-                        TransactionState::Completed
-                    } else {
-                        TransactionState::Terminated
-                    }
+                    TransactionState::Completed
                 } else {
                     TransactionState::Terminated
                 }