Commit 82c0854
authored
build: pin every dependency to an exact version, including runtime tool installs (#77)
* build(renovate): pin every dependency to an exact version
Org-wide policy: no ranges, in any repo, in any ecosystem. A range means the
version you get depends on when you install -- CI, a laptop and a release build
can each resolve differently -- and a bad upstream release lands without a PR
anyone reviewed.
Renovate now raises a "Pin dependencies" PR for anything that regresses to a
range, and every upgrade arrives as a reviewable PR that CI has to pass. That is
the point rather than the cost: the same number of upgrades, each one visible.
A survey found the repos were already almost entirely pinned -- Maven and Gradle
had no ranges at all, and only four dependencies across two repos needed
changing (reqstool-vscode#103, reqstool-client#440). This keeps them that way.
Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
* build(ci): pin the tools the workflows install at runtime
The earlier survey only looked at package manifests, and missed a whole class of
dependency: tools installed inside a workflow. They execute in CI and some of
them feed a publish, so an unpinned one is exactly the risk pinning exists to
remove.
Worst of them was `docker run renovate/renovate` with no tag at all -- :latest on
every run, so that job's behaviour could change with no commit anywhere. Now
44.32.5.
Also pinned: zizmor 1.29.0, yamllint 1.38.0, PyYAML 6.0.3, hatch 1.18.0, twine
7.0.0, @fission-ai/openspec 1.9.0. Each carries a `# renovate:` comment, so they
are tracked rather than merely frozen -- the distinction the four earlier pins
were about.
The custom manager gains one matchString for the inline `tool==1.2.3` and
`pkg@1.2.3` forms. The docker image reuses the existing `VERSION="..."` form via
a variable, rather than a third pattern: an inline comment there would have
needed backticks, which bash would have run as command substitution.
install-reqstool stays unpinned on purpose, and now says so. The build matrix
runs it with reqstool-source: [pypi, main] precisely to test against whatever
reqstool currently releases; pinning it would defeat the check it exists for.
Verified all ten annotations are discovered by the manager's regexes.
Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
---------
Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>1 parent 0a0152b commit 82c0854
7 files changed
Lines changed: 28 additions & 7 deletions
File tree
- .github
- actions/install-reqstool
- workflows
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
30 | 33 | | |
31 | 34 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
9 | 18 | | |
10 | 19 | | |
11 | 20 | | |
| |||
61 | 70 | | |
62 | 71 | | |
63 | 72 | | |
| 73 | + | |
64 | 74 | | |
65 | 75 | | |
66 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | | - | |
| 41 | + | |
| 42 | + | |
41 | 43 | | |
42 | 44 | | |
43 | 45 | | |
| |||
89 | 91 | | |
90 | 92 | | |
91 | 93 | | |
92 | | - | |
| 94 | + | |
| 95 | + | |
93 | 96 | | |
94 | 97 | | |
95 | 98 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
| 39 | + | |
39 | 40 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
| 28 | + | |
| 29 | + | |
28 | 30 | | |
29 | 31 | | |
30 | | - | |
| 32 | + | |
31 | 33 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
| 59 | + | |
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
| 67 | + | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| |||
0 commit comments