Skip to content

Commit 9b42d00

Browse files
author
dpundir
committed
remove unnecessary copies from the old go loop variable
1 parent cbc753f commit 9b42d00

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

internal/controller/group_controller.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -920,14 +920,12 @@ func (r *GroupReconciler) createUsersInBackendAndCache(ctx context.Context,
920920
g.SetLimit(backendClient.MaxConcurrency())
921921

922922
for i, req := range toCreate {
923-
idx := i
924-
cr := req
925923
g.Go(func() error {
926-
newUser, err := backendClient.CreateUser(gctx, cr.user)
924+
newUser, err := backendClient.CreateUser(gctx, req.user)
927925
if err != nil {
928926
return err
929927
}
930-
results[idx] = userCreateResult{email: cr.email, id: newUser.ID}
928+
results[i] = userCreateResult{email: req.email, id: newUser.ID}
931929
return nil
932930
})
933931
}

0 commit comments

Comments
 (0)