Skip to content

Commit 6587e6e

Browse files
committed
Merge remote-tracking branch 'upstream/main' into rhoai-3.2
2 parents 0b8fb8f + b32e496 commit 6587e6e

File tree

6 files changed

+21
-14
lines changed

6 files changed

+21
-14
lines changed

.tekton/odh-workbench-jupyter-trustyai-cpu-py312-pull-request.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ spec:
4545
value:
4646
- linux-extra-fast/amd64
4747
- linux-m2xlarge/arm64
48+
- linux/ppc64le
4849
- linux/s390x
4950
- name: image-expires-after
5051
value: 5d

codeserver/ubi9-python-3.12/Dockerfile.cpu

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ pip install --no-cache-dir uv
5959
source ./devel_env_setup.sh
6060
# This may have to download and compile some dependencies, and as we don't lock requirements from `build-system.requires`,
6161
# we often don't know the correct hashes and `--require-hashes` would therefore fail on non amd64, where building is common.
62-
UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --requirements=./pylock.toml
62+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --requirements=./pylock.toml
6363
EOF
6464

6565
# dummy file to make image build wait for this stage
@@ -291,7 +291,7 @@ RUN --mount=type=cache,target=/root/.cache/uv \
291291
--mount=type=cache,from=whl-cache,source=/wheelsdir/,target=/wheelsdir/,rw /bin/bash <<'EOF'
292292
set -Eeuxo pipefail
293293
if [[ $(uname -m) == "ppc64le" ]] || [[ $(uname -m) == "s390x" ]]; then
294-
uv pip install /wheelsdir/*.whl
294+
UV_NO_CACHE=false uv pip install /wheelsdir/*.whl
295295
fi
296296
EOF
297297

@@ -300,8 +300,7 @@ RUN --mount=type=cache,target=/root/.cache/uv /bin/bash <<'EOF'
300300
set -Eeuxo pipefail
301301
echo "Installing softwares and packages"
302302
# we can ensure wheels are consumed from the cache only by restricting internet access for uv install with '--offline' flag
303-
# TODO(jdanek): seen some builds fail on GitHub Actions with --offline and see no need to limit ourselves to the cache, will remove this
304-
UV_LINK_MODE=copy uv pip install --cache-dir /root/.cache/uv --requirements=./pylock.toml
303+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --offline --cache-dir /root/.cache/uv --requirements=./pylock.toml
305304
# Note: debugpy wheel availabe on pypi (in uv cache) is none-any but bundles amd64.so files
306305
# Build debugpy from source instead
307306
UV_LINK_MODE=copy uv pip install --no-cache git+https://github.com/microsoft/debugpy.git@v$(grep -A1 '\"debugpy\"' ./pylock.toml | grep -Eo '\b[0-9\.]+\b')

codeserver/ubi9-python-3.12/Dockerfile.konflux.cpu

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ pip install --no-cache-dir uv
6262
source ./devel_env_setup.sh
6363
# This may have to download and compile some dependencies, and as we don't lock requirements from `build-system.requires`,
6464
# we often don't know the correct hashes and `--require-hashes` would therefore fail on non amd64, where building is common.
65-
UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --requirements=./pylock.toml
65+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --requirements=./pylock.toml
6666
EOF
6767

6868
# dummy file to make image build wait for this stage
@@ -302,7 +302,7 @@ RUN --mount=type=cache,target=/root/.cache/uv \
302302
--mount=type=cache,from=whl-cache,source=/wheelsdir/,target=/wheelsdir/,rw /bin/bash <<'EOF'
303303
set -Eeuxo pipefail
304304
if [[ $(uname -m) == "ppc64le" ]] || [[ $(uname -m) == "s390x" ]]; then
305-
uv pip install /wheelsdir/*.whl
305+
UV_NO_CACHE=false uv pip install /wheelsdir/*.whl
306306
fi
307307
EOF
308308

@@ -311,8 +311,7 @@ RUN --mount=type=cache,target=/root/.cache/uv /bin/bash <<'EOF'
311311
set -Eeuxo pipefail
312312
echo "Installing softwares and packages"
313313
# we can ensure wheels are consumed from the cache only by restricting internet access for uv install with '--offline' flag
314-
# TODO(jdanek): seen some builds fail on GitHub Actions with --offline and see no need to limit ourselves to the cache, will remove this
315-
UV_LINK_MODE=copy uv pip install --cache-dir /root/.cache/uv --requirements=./pylock.toml
314+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --offline --cache-dir /root/.cache/uv --requirements=./pylock.toml
316315
# Note: debugpy wheel availabe on pypi (in uv cache) is none-any but bundles amd64.so files
317316
# Build debugpy from source instead
318317
UV_LINK_MODE=copy uv pip install --no-cache git+https://github.com/microsoft/debugpy.git@v$(grep -A1 '\"debugpy\"' ./pylock.toml | grep -Eo '\b[0-9\.]+\b')

jupyter/trustyai/ubi9-python-3.12/Dockerfile.cpu

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ source ./devel_env_setup.sh
5151
# This may have to download and compile some dependencies, and as we don't lock requirements from `build-system.requires`,
5252
# we often don't know the correct hashes and `--require-hashes` would therefore fail on non amd64, where building is common.
5353
# RHAIENG-2111: building pandas requires cython from PyPI
54-
UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
54+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
5555
EOF
5656

5757
####################
@@ -227,7 +227,7 @@ RUN --mount=type=cache,from=whl-cache,source=/wheelsdir/,target=/wheelsdir/,rw \
227227
set -Eeuxo pipefail
228228
ARCH=$(uname -m)
229229
if [ "$ARCH" = "ppc64le" ] || [ "$ARCH" = "s390x" ]; then
230-
UV_LINK_MODE=copy uv pip install /wheelsdir/*.whl accelerate --cache-dir /root/.cache/uv
230+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install /wheelsdir/*.whl accelerate --cache-dir /root/.cache/uv
231231
fi
232232
EOF
233233

@@ -236,7 +236,7 @@ set -Eeuxo pipefail
236236
echo "Installing softwares and packages"
237237
# we can ensure wheels are consumed from the cache only by restricting internet access for uv install with '--offline' flag
238238
# RHAIENG-2111: building pandas requires cython from PyPI
239-
UV_LINK_MODE=copy uv pip install --cache-dir /root/.cache/uv --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
239+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --offline --cache-dir /root/.cache/uv --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
240240
# Note: debugpy wheel availabe on pypi (in uv cache) is none-any but bundles amd64.so files
241241
# Build debugpy from source instead
242242
UV_LINK_MODE=copy uv pip install --no-cache git+https://github.com/microsoft/debugpy.git@v$(grep -A1 '\"debugpy\"' ./pylock.toml | grep -Eo '\b[0-9\.]+\b')

jupyter/trustyai/ubi9-python-3.12/Dockerfile.konflux.cpu

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ source ./devel_env_setup.sh
6464
# This may have to download and compile some dependencies, and as we don't lock requirements from `build-system.requires`,
6565
# we often don't know the correct hashes and `--require-hashes` would therefore fail on non amd64, where building is common.
6666
# RHAIENG-2111: building pandas requires cython from PyPI
67-
UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
67+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --strict --no-deps --refresh --no-config --no-progress --verify-hashes --compile-bytecode --index-strategy=unsafe-best-match --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
6868
EOF
6969

7070
####################
@@ -243,7 +243,7 @@ RUN --mount=type=cache,from=whl-cache,source=/wheelsdir/,target=/wheelsdir/,rw \
243243
set -Eeuxo pipefail
244244
ARCH=$(uname -m)
245245
if [ "$ARCH" = "ppc64le" ] || [ "$ARCH" = "s390x" ]; then
246-
UV_LINK_MODE=copy uv pip install /wheelsdir/*.whl accelerate --cache-dir /root/.cache/uv
246+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install /wheelsdir/*.whl accelerate --cache-dir /root/.cache/uv
247247
fi
248248
EOF
249249

@@ -252,7 +252,7 @@ set -Eeuxo pipefail
252252
echo "Installing softwares and packages"
253253
# we can ensure wheels are consumed from the cache only by restricting internet access for uv install with '--offline' flag
254254
# RHAIENG-2111: building pandas requires cython from PyPI
255-
UV_LINK_MODE=copy uv pip install --cache-dir /root/.cache/uv --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
255+
UV_NO_CACHE=false UV_LINK_MODE=copy uv pip install --offline --cache-dir /root/.cache/uv --extra-index-url https://pypi.org/simple --requirements=./pylock.toml
256256
# Note: debugpy wheel availabe on pypi (in uv cache) is none-any but bundles amd64.so files
257257
# Build debugpy from source instead
258258
UV_LINK_MODE=copy uv pip install --no-cache git+https://github.com/microsoft/debugpy.git@v$(grep -A1 '\"debugpy\"' ./pylock.toml | grep -Eo '\b[0-9\.]+\b')

jupyter/trustyai/ubi9-python-3.12/devel_env_setup.sh

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,14 @@ if [[ $(uname -m) == "ppc64le" ]] || [[ $(uname -m) == "s390x" ]]; then
2929

3030
# install development packages
3131
dnf install -y --setopt=keepcache=1 https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm
32+
dnf clean all
33+
# enable codeready-builder/crb repository
34+
dnf install -y dnf-plugins-core
35+
if command -v subscription-manager &> /dev/null; then
36+
subscription-manager repos --enable "codeready-builder-for-rhel-9-$(uname -m)-rpms"
37+
else
38+
dnf config-manager --set-enabled crb
39+
fi
3240
# patchelf: needed by `auditwheel repair`
3341
dnf install -y --setopt=keepcache=1 fribidi-devel lcms2-devel libimagequant-devel patchelf \
3442
libraqm-devel openjpeg2-devel tcl-devel tk-devel unixODBC-devel

0 commit comments

Comments
 (0)