Skip to content

Commit df99448

Browse files
authored
Fix Synchronous name spelling (#28)
* Fix Synchronous name spelling * Update ReactiveExtensionsTests.cs
1 parent f7bed15 commit df99448

File tree

4 files changed

+7
-7
lines changed

4 files changed

+7
-7
lines changed

.editorconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -236,6 +236,7 @@ dotnet_diagnostic.CA2242.severity = error
236236
dotnet_diagnostic.RCS1001.severity = error
237237
dotnet_diagnostic.RCS1018.severity = error
238238
dotnet_diagnostic.RCS1037.severity = error
239+
dotnet_diagnostic.RCS1047.severity = none
239240
dotnet_diagnostic.RCS1055.severity = error
240241
dotnet_diagnostic.RCS1062.severity = error
241242
dotnet_diagnostic.RCS1066.severity = error

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@ Extensions for concerns found in System.Reactive that make consuming the library
3636
- OnErrorRetry
3737
- TakeUntil
3838
- SyncronizeAsync
39-
- SubscribeSynchronus
39+
- SubscribeSynchronous

src/ReactiveMarbles.Extensions.Tests/ReactiveExtensionsTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public void SubscribeSynchronus_RunsWithAsyncTasksInSubscriptions()
7777
var itterations = 0;
7878
var subject = new Subject<bool>();
7979
using var disposable = subject
80-
.SubscribeSynchronus(async x =>
80+
.SubscribeSynchronous(async x =>
8181
{
8282
if (x)
8383
{

src/ReactiveMarbles.Extensions/ReactiveExtensions.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,6 @@ public static IObservable<TSource> TakeUntil<TSource>(this IObservable<TSource>
913913
/// <typeparam name="T">The type of the elements in the source sequence.</typeparam>
914914
/// <param name="source">The source.</param>
915915
/// <returns>An Observable of T and a release mechanism.</returns>
916-
[SuppressMessage("Roslynator", "RCS1047:Non-asynchronous method name should not end with 'Async'.", Justification = "To avoid naming conflicts.")]
917916
public static IObservable<(T Value, IDisposable Sync)> SynchronizeAsync<T>(this IObservable<T> source) =>
918917
Observable.Create<(T Value, IDisposable Sync)>(observer =>
919918
{
@@ -930,7 +929,7 @@ public static IObservable<TSource> TakeUntil<TSource>(this IObservable<TSource>
930929
/// <param name="onError">The on error.</param>
931930
/// <param name="onCompleted">The on completed.</param>
932931
/// <returns><see cref="IDisposable"/> object used to unsubscribe from the observable sequence.</returns>
933-
public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Func<T, Task> onNext, Action<Exception> onError, Action onCompleted) =>
932+
public static IDisposable SubscribeSynchronous<T>(this IObservable<T> source, Func<T, Task> onNext, Action<Exception> onError, Action onCompleted) =>
934933
source.SynchronizeAsync().Subscribe(
935934
async observer =>
936935
{
@@ -948,7 +947,7 @@ public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Fun
948947
/// <param name="onNext">Action to invoke for each element in the observable sequence.</param>
949948
/// <param name="onError">Action to invoke upon exceptional termination of the observable sequence.</param>
950949
/// <returns><see cref="IDisposable"/> object used to unsubscribe from the observable sequence.</returns>
951-
public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Func<T, Task> onNext, Action<Exception> onError) =>
950+
public static IDisposable SubscribeSynchronous<T>(this IObservable<T> source, Func<T, Task> onNext, Action<Exception> onError) =>
952951
source.SynchronizeAsync().Subscribe(
953952
async observer =>
954953
{
@@ -966,7 +965,7 @@ public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Fun
966965
/// <param name="onCompleted">Action to invoke upon graceful termination of the observable sequence.</param>
967966
/// <returns><see cref="IDisposable"/> object used to unsubscribe from the observable sequence.</returns>
968967
/// <exception cref="ArgumentNullException"><paramref name="source"/> or <paramref name="onNext"/> or <paramref name="onCompleted"/> is <c>null</c>.</exception>
969-
public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Func<T, Task> onNext, Action onCompleted) =>
968+
public static IDisposable SubscribeSynchronous<T>(this IObservable<T> source, Func<T, Task> onNext, Action onCompleted) =>
970969
source.SynchronizeAsync().Subscribe(
971970
async observer =>
972971
{
@@ -982,7 +981,7 @@ public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Fun
982981
/// <param name="source">Observable sequence to subscribe to.</param>
983982
/// <param name="onNext">Action to invoke for each element in the observable sequence.</param>
984983
/// <returns><see cref="IDisposable"/> object used to unsubscribe from the observable sequence.</returns>
985-
public static IDisposable SubscribeSynchronus<T>(this IObservable<T> source, Func<T, Task> onNext) =>
984+
public static IDisposable SubscribeSynchronous<T>(this IObservable<T> source, Func<T, Task> onNext) =>
986985
source.SynchronizeAsync().Subscribe(
987986
async observer =>
988987
{

0 commit comments

Comments
 (0)