chore: Removed custom logic for extracting RGB and alpha components, as the new setBorderColor method handles it internally. (#941)

dmitry-blackwave · web-flow · commit 28552a9feb9c · 2024-10-25T10:48:11.000+09:00
Co-authored-by: Dmitry Belov &lt;dmitry.belov@studocu.com&gt;
diff --git a/android/src/main/java/com/reactnativemenu/MenuViewManager.kt b/android/src/main/java/com/reactnativemenu/MenuViewManager.kt
@@ -152,9 +152,7 @@ class MenuViewManager: ReactClippingViewManager<MenuView>() {
 
   @ReactPropGroup(names = [ViewProps.BORDER_COLOR, ViewProps.BORDER_LEFT_COLOR, ViewProps.BORDER_RIGHT_COLOR, ViewProps.BORDER_TOP_COLOR, ViewProps.BORDER_BOTTOM_COLOR, ViewProps.BORDER_START_COLOR, ViewProps.BORDER_END_COLOR], customType = "Color")
   fun setBorderColor(view: ReactViewGroup, index: Int, color: Int?) {
-    val rgbComponent = if (color == null) YogaConstants.UNDEFINED else (color and 0x00FFFFFF).toFloat()
-    val alphaComponent = if (color == null) YogaConstants.UNDEFINED else (color ushr 24).toFloat()
-    view.setBorderColor(SPACING_TYPES[index], rgbComponent, alphaComponent)
+    view.setBorderColor(index, color)
   }
 
   @ReactProp(name = ViewProps.OVERFLOW)

Original file line number	Diff line number	Diff line change
`@@ -152,9 +152,7 @@ class MenuViewManager: ReactClippingViewManager<MenuView>() {`
`152`	`152`
`153`	`153`	`@ReactPropGroup(names = [ViewProps.BORDER_COLOR, ViewProps.BORDER_LEFT_COLOR, ViewProps.BORDER_RIGHT_COLOR, ViewProps.BORDER_TOP_COLOR, ViewProps.BORDER_BOTTOM_COLOR, ViewProps.BORDER_START_COLOR, ViewProps.BORDER_END_COLOR], customType = "Color")`
`154`	`154`	`fun setBorderColor(view: ReactViewGroup, index: Int, color: Int?) {`
`155`		`- val rgbComponent = if (color == null) YogaConstants.UNDEFINED else (color and 0x00FFFFFF).toFloat()`
`156`		`- val alphaComponent = if (color == null) YogaConstants.UNDEFINED else (color ushr 24).toFloat()`
`157`		`- view.setBorderColor(SPACING_TYPES[index], rgbComponent, alphaComponent)`
	`155`	`+ view.setBorderColor(index, color)`
`158`	`156`	`}`
`159`	`157`
`160`	`158`	`@ReactProp(name = ViewProps.OVERFLOW)`