RDK-61444 : Network Manager Plugin to support Scan Specific SSID by jincysam87 · Pull Request #306 · rdkcentral/networkmanager

jincysam87 · 2026-05-08T15:59:31Z

Reason for change: Support to scan multiple SSIDs
Test Procedure: Test wifi scan API with multiple SSIDs
Risks: Low
Signed-off-by: jincysaramma_sam@comcast.com

Sync

rdkcmf-jenkins · 2026-05-08T16:00:39Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 3a19acc

Report detail: gist'

Copilot

Pull request overview

This PR updates the GNOME NetworkManager WiFi scan path to support scanning with multiple SSID filters (instead of a single optional SSID string), aligning the plugin with the requirement to “scan multiple SSIDs”.

Changes:

Updated wifiScanRequest API to accept a std::vector<std::string> of SSIDs to filter.
Built a GVariant aay SSID list for nm_device_wifi_request_scan_options_async() when filters are provided; otherwise falls back to a normal scan.
Updated the GNOME proxy to pass the SSID filter list through to the WiFi manager.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
plugin/gnome/NetworkManagerGnomeWIFI.h	Changes `wifiScanRequest` signature to take a vector of SSIDs.
plugin/gnome/NetworkManagerGnomeWIFI.cpp	Implements building a multi-SSID scan options payload and triggers filtered vs unfiltered scan.
plugin/gnome/NetworkManagerGnomeProxy.cpp	Passes the SSID filter list to the updated scan request API.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

            bool wifiConnectedSSIDInfo(Exchange::INetworkManager::WiFiSSIDInfo &ssidinfo);
            bool wifiConnect(const Exchange::INetworkManager::WiFiConnectTo &ssidInfo);
-            bool wifiScanRequest(std::string ssidReq = "");
+            bool wifiScanRequest(std::vector<std::string> ssidsToFilter = {});


+            if(!ssidsToFilter.empty())
            {
-                NMLOG_INFO("starting wifi scanning .. %s", ssidReq.c_str());
+                NMLOG_INFO("Starting wifi scanning for %d SSIDs:", ssidsToFilter.size());


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-05-08T16:06:42Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: ec5d3a2

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

            bool wifiConnectedSSIDInfo(Exchange::INetworkManager::WiFiSSIDInfo &ssidinfo);
            bool wifiConnect(const Exchange::INetworkManager::WiFiConnectTo &ssidInfo);
-            bool wifiScanRequest(std::string ssidReq = "");
+            bool wifiScanRequest(std::vector<std::string> ssidsToFilter = {});


+            if(!ssidsToFilter.empty())
            {
-                NMLOG_INFO("starting wifi scanning .. %s", ssidReq.c_str());
+                NMLOG_INFO("Starting wifi scanning for %d SSIDs:", ssidsToFilter.size());


Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-05-08T16:14:44Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 3aba5bb

Report detail: gist'

rdkcmf-jenkins · 2026-05-08T16:15:33Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 7032c46

Report detail: gist'

rdkcmf-jenkins · 2026-05-15T19:59:28Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 66a899a

Report detail: gist'

rdkcmf-jenkins · 2026-05-15T20:00:20Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 66a899a

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 4 comments.

rdkcmf-jenkins · 2026-05-15T20:14:44Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 2f43fb2

Report detail: gist'

rdkcmf-jenkins · 2026-05-18T11:20:25Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 2f43fb2

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (3)

plugin/NetworkManagerJsonRpc.cpp:670

This malformed frequency-array path also returns with rc still set to Core::ERROR_GENERAL. Set rc = Core::ERROR_BAD_REQUEST before returning so non-numeric entries are reported as invalid request parameters rather than generic failures.

					else
					{
						NMLOG_ERROR("Unexpected variant type in frequency array.");
	                    returnJson(rc);

legacy/LegacyWiFiManagerAPIs.cpp:662

This malformed frequency-array path also returns with rc still set to Core::ERROR_GENERAL. Set rc = Core::ERROR_BAD_REQUEST before returning so non-numeric entries are reported as invalid request parameters rather than generic failures.

					else
					{
						NMLOG_ERROR("Unexpected variant type in frequency array.");
	                    returnJson(rc);

plugin/gnome/gdbus/NetworkManagerGdbusProxy.cpp:223

The GDBus backend now accepts the SSID/frequency iterators but still ignores them and always starts an unfiltered scan while returning success. With the updated API/docs, callers requesting specific SSIDs or bands will receive unfiltered results on this backend. Populate the same filter state used by event filtering or return a not-supported/bad-request status when filters are provided.

        uint32_t NetworkManagerImplementation::StartWiFiScan(IWIFIFrequencyIterator* const frequencies /* @in */, IStringIterator* const ssids/* @in */)
        {
            uint32_t rc = Core::ERROR_GENERAL;
            _nmGdbusEvents->setwifiScanOptions(true); /* Enable event posting */
            if(_nmGdbusClient->startWifiScan())

rdkcmf-jenkins · 2026-05-18T14:58:45Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 35b7986

Report detail: gist'

rdkcmf-jenkins · 2026-05-18T16:16:42Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 0eddda2

Report detail: gist'

rdkcmf-jenkins · 2026-05-18T16:17:55Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: b69b514

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

rdkcmf-jenkins · 2026-05-18T17:35:36Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: a4b96ec

Report detail: gist'

rdkcmf-jenkins · 2026-05-18T17:40:12Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 534dd6b

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

rdkcmf-jenkins · 2026-05-18T17:47:21Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/306/rdkcentral/networkmanager
Commit: 528a17e

Report detail: gist'

Copilot

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

plugin/gnome/gdbus/NetworkManagerGdbusProxy.cpp:223

This backend accepts the new frequency iterator (and the existing SSID iterator) but still ignores both before starting the scan. In an ENABLE_GNOME_GDBUS build, filtered StartWiFiScan requests will return success while emitting unfiltered results; either apply the iterators to the scan/result filtering path or return a not-supported/error status when filters are provided.

        uint32_t NetworkManagerImplementation::StartWiFiScan(IWIFIFrequencyIterator* const frequencies /* @in */, IStringIterator* const ssids/* @in */)
        {
            uint32_t rc = Core::ERROR_GENERAL;
            _nmGdbusEvents->setwifiScanOptions(true); /* Enable event posting */
            if(_nmGdbusClient->startWifiScan())

jincysam87 added 13 commits April 22, 2026 22:44

Merge pull request #19 from rdkcentral/develop

594597f

Sync

Merge branch 'rdkcentral:develop' into develop

712c8e8

Merge branch 'rdkcentral:develop' into develop

1f5f624

Merge branch 'rdkcentral:develop' into develop

7a0e1f8

Update NetworkManagerGnomeProxy.cpp

1fd41f2

Update NetworkManagerGnomeWIFI.cpp

3e1b457

Update NetworkManagerGnomeWIFI.h

e0ed060

Update NetworkManagerGnomeWIFI.cpp

5448555

Update NetworkManagerImplementation.cpp

17d1c07

Update NetworkManagerImplementation.cpp

c79bae1

Update NetworkManagerImplementation.cpp

bb2d211

Update NetworkManagerImplementation.cpp

96e9296

Update NetworkManagerGnomeWIFI.cpp

3a19acc

Copilot AI review requested due to automatic review settings May 8, 2026 15:59

jincysam87 requested a review from a team as a code owner May 8, 2026 15:59

Copilot started reviewing on behalf of jincysam87 May 8, 2026 16:00 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Potential fix for pull request finding

ec5d3a2

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 8, 2026 16:05

Copilot started reviewing on behalf of jincysam87 May 8, 2026 16:06 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Potential fix for pull request finding

216fb46

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 8, 2026 16:13

Update NetworkManagerGnomeWIFI.cpp

3aba5bb

Copilot started reviewing on behalf of jincysam87 May 8, 2026 16:14 View session

Update NetworkManagerGnomeWIFI.h

7032c46

Copilot AI reviewed May 15, 2026

View reviewed changes

Comment thread plugin/rdk/NetworkManagerRDKProxy.cpp Outdated

Comment thread plugin/NetworkManagerJsonRpc.cpp

Comment thread legacy/LegacyWiFiManagerAPIs.cpp

Comment thread legacy/LegacyWiFiManagerAPIs.cpp

Update LegacyWiFiManagerAPIs.cpp

2f43fb2

Update NetworkManagerRDKProxy.cpp

35b7986

Copilot AI review requested due to automatic review settings May 18, 2026 14:53

Copilot started reviewing on behalf of jincysam87 May 18, 2026 14:54 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread legacy/LegacyWiFiManagerAPIs.cpp

Comment thread plugin/NetworkManagerJsonRpc.cpp

Comment thread legacy/LegacyWiFiManagerAPIs.cpp

Update l2_test_LegacyPlugin_WiFiManagerAPIs.cpp

0eddda2

Update l2_test_libnmproxyWifi.cpp

b69b514

Copilot AI review requested due to automatic review settings May 18, 2026 16:16

Copilot started reviewing on behalf of jincysam87 May 18, 2026 16:17 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread definition/NetworkManager.json

Comment thread plugin/gnome/NetworkManagerGnomeWIFI.cpp

Comment thread plugin/NetworkManagerJsonRpc.cpp

Update l2_test_rdkproxy.cpp

a4b96ec

Update l2_test_rdkproxy.cpp

534dd6b

Copilot AI review requested due to automatic review settings May 18, 2026 17:39

Copilot started reviewing on behalf of jincysam87 May 18, 2026 17:39 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Comment thread tests/l2Test/legacy/l2_test_LegacyPlugin_WiFiManagerAPIs.cpp Outdated

Potential fix for pull request finding

528a17e

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 18, 2026 17:45

Copilot started reviewing on behalf of jincysam87 May 18, 2026 17:46 View session

Copilot AI reviewed May 18, 2026

View reviewed changes

Conversation

jincysam87 commented May 8, 2026

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

rdkcmf-jenkins commented May 8, 2026

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 15, 2026

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

rdkcmf-jenkins commented May 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects