The DataFactory interface is missing the fromTerm and fromQuad methods

[matthieubosquet]

The RDF/JS spec defines two methods fromTerm and fromQuad that are missing from the interface definition in this package.

Is it intentional?

Interface definition in @rdfjs/types:

types/data-model.d.ts

Lines 239 to 290 in ec006f7

	export interface DataFactory<OutQuad extends BaseQuad = Quad, InQuad extends BaseQuad = OutQuad> {
	/**
	* @param value The IRI for the named node.
	* @return A new instance of NamedNode.
	* @see NamedNode
	*/
	namedNode<Iri extends string = string>(value: Iri): NamedNode<Iri>;
	/**
	* @param value The optional blank node identifier.
	* @return A new instance of BlankNode.
	* If the `value` parameter is undefined a new identifier
	* for the blank node is generated for each call.
	* @see BlankNode
	*/
	blankNode(value?: string): BlankNode;
	/**
	* @param value The literal value.
	* @param languageOrDatatype The optional language or datatype.
	* If `languageOrDatatype` is a NamedNode,
	* then it is used for the value of `NamedNode.datatype`.
	* Otherwise `languageOrDatatype` is used for the value
	* of `NamedNode.language`.
	* @return A new instance of Literal.
	* @see Literal
	*/
	literal(value: string, languageOrDatatype?: string | NamedNode): Literal;
	/**
	* This method is optional.
	* @param value The variable name
	* @return A new instance of Variable.
	* @see Variable
	*/
	variable?(value: string): Variable;
	/**
	* @return An instance of DefaultGraph.
	*/
	defaultGraph(): DefaultGraph;
	/**
	* @param subject The quad subject term.
	* @param predicate The quad predicate term.
	* @param object The quad object term.
	* @param graph The quad graph term.
	* @return A new instance of Quad.
	* @see Quad
	*/
	quad(subject: InQuad['subject'], predicate: InQuad['predicate'], object: InQuad['object'], graph?: InQuad['graph']): OutQuad;
	}

Spec definition:

[matthieubosquet]

See: #46

[tpluscode]

Is it intentional?

I do not think it's intentional.
See, the types themselves were started 7 years ago, without the missing methods: https://github.com/DefinitelyTyped/DefinitelyTyped/blame/e5b56fcf1b8133cc599e9e6d7ff155c4ac7d75be/types/rdf-js/index.d.ts#L204-L266
The new methods were added 2 years later by @elf-pavlik: rdfjs/data-model-spec@52c631d
It would appear that no one noticed until now :)

[elf-pavlik]

The new methods were added 2 years later by @elf-pavlik: rdfjs/data-model-spec@52c631d

It was requested in rdfjs/data-model-spec#137

[jeswr]

@matthieubosquet - I think this can now be closed.