Skip to content

fix count(*) #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: IBM-techpreview
Choose a base branch
from
Open

fix count(*) #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions velox/experimental/cudf/exec/ToCudf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@ bool CompileState::compile(bool allowCpuFallback) {

// Check projects separately.
if (projectPlanNode) {
if (projectPlanNode->sources()[0]->outputType()->size() == 0 ||
projectPlanNode->outputType()->size() == 0) {
return false;
}
if (!canBeEvaluatedByCudf(
projectPlanNode->projections(), ctx->task->queryCtx().get())) {
return false;
Expand All @@ -155,6 +159,12 @@ bool CompileState::compile(bool allowCpuFallback) {
return false;
}

if (aggregationPlanNode->sources()[0]->outputType()->size() == 0) {
// We cannot hande RowVectors with a length but no data.
// This is the case with count(*) global (without groupby)
return false;
}

// Use the centralized canBeEvaluatedByCudf function which includes
// expression expansion
return canBeEvaluatedByCudf(
Expand Down
16 changes: 16 additions & 0 deletions velox/experimental/cudf/tests/AggregationTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,22 @@ TEST_F(AggregationTest, avgPartialFinalGlobal) {
assertQuery(op, "SELECT avg(c1), avg(c2), avg(c4), avg(c5) FROM tmp");
}

TEST_F(AggregationTest, countStarGlobal) {
auto vectors = makeVectors(rowType_, 10, 100);

createDuckDbTable(vectors);

auto op = PlanBuilder()
.values(vectors)
.filter("c0 > 10")
.project({})
.partialAggregation({}, {"count(*)"})
.finalAggregation()
.planNode();

assertQuery(op, "SELECT count(*) FROM tmp WHERE c0 > 10");
}

TEST_F(AggregationTest, countSingleGroupBy) {
auto vectors = makeVectors(rowType_, 10, 100);
createDuckDbTable(vectors);
Expand Down
Loading