Merge pull request #10 from bdice/fix-cache-save

Fix ccache saving

Author: bdice

.github/disabled-workflows/experimental.yml

@@ -103,13 +103,12 @@ jobs:
           name: join
           path: velox/_build/debug/velox/exec/tests/velox_join_fuzzer_test
 
-
   presto-java-aggregation-fuzzer-run:
     runs-on: linux-amd64-cpu8
     container: ghcr.io/facebookincubator/velox-dev:presto-java
     timeout-minutes: 120
     env:
-      CCACHE_DIR: "${GITHUB_WORKSPACE}/.ccache/"
+      CCACHE_DIR: "${{ github.workspace }}/.ccache/"
       LINUX_DISTRO: "centos"
     steps:
 

.github/disabled-workflows/scheduled.yml

@@ -92,7 +92,7 @@ jobs:
     container: ghcr.io/facebookincubator/velox-dev:centos9
     timeout-minutes: 120
     env:
-      CCACHE_DIR: "${GITHUB_WORKSPACE}/.ccache"
+      CCACHE_DIR: "${{ github.workspace }}/.ccache"
       LINUX_DISTRO: "ubuntu"
       MAKEFLAGS: "NUM_THREADS=${{ inputs.numThreads || 16 }} MAX_HIGH_MEM_JOBS=${{ inputs.maxHighMemJobs || 8 }} MAX_LINK_JOBS=${{ inputs.maxLinkJobs || 4 }}"
 
@@ -892,3 +892,68 @@ jobs:
           path: |
             /tmp/window_fuzzer_repro
             /tmp/server.log
+
+  presto-java-writer-fuzzer-run:
+    name: Writer Fuzzer with Presto as source of truth
+    needs: compile
+    runs-on: ubuntu-latest
+    container: ghcr.io/facebookincubator/velox-dev:presto-java
+    timeout-minutes: 120
+    env:
+      CCACHE_DIR: "${{ github.workspace }}/.ccache/"
+      LINUX_DISTRO: "centos"
+    steps:
+
+      - name: Download writer fuzzer
+        uses: actions/download-artifact@v4
+        with:
+          name: writer
+
+      - name: "Checkout Repo"
+        uses: actions/checkout@v4
+        with:
+          path: velox
+          submodules: 'recursive'
+          ref: "${{ inputs.ref }}"
+
+      - name: Fix git permissions
+        # Usually actions/checkout does this but as we run in a container
+        # it doesn't work
+        run: git config --global --add safe.directory ${GITHUB_WORKSPACE}/velox
+
+      - name: "Run Writer Fuzzer"
+        run: |
+          cd  velox
+          cp ./scripts/presto/etc/hive.properties $PRESTO_HOME/etc/catalog
+          ls -lR $PRESTO_HOME/etc
+          echo "jvm config content:"
+          cat $PRESTO_HOME/etc/jvm.config
+          $PRESTO_HOME/bin/launcher run -v > /tmp/server.log 2>&1 &
+          ls -lR /var/log
+          # Sleep for 60 seconds to allow Presto server to start.
+          sleep 60
+          /opt/presto-cli --version
+          /opt/presto-cli --server 127.0.0.1:8080 --execute 'CREATE SCHEMA hive.tpch;'
+          cd -
+          mkdir -p /tmp/writer_fuzzer_repro/logs/
+          chmod -R 777 /tmp/writer_fuzzer_repro
+          chmod +x velox_writer_fuzzer_test
+          ./velox_writer_fuzzer_test \
+                --seed ${RANDOM} \
+                --duration_sec $DURATION \
+                --minloglevel=0 \
+                --stderrthreshold=2 \
+                --req_timeout_ms 60000 \
+                --log_dir=/tmp/writer_fuzzer_repro/logs \
+                --presto_url=http://127.0.0.1:8080 \
+          && echo -e "\n\Writer fuzzer run finished successfully."
+
+      - name: Archive writer production artifacts
+        if: ${{ !cancelled() }}
+        uses: actions/upload-artifact@v4
+        with:
+          name: presto-sot-writer-fuzzer-failure-artifacts
+          path: |
+            /tmp/writer_fuzzer_repro
+            /tmp/server.log
+            /var/log

.github/workflows/linux-build.yml

@@ -40,7 +40,7 @@ jobs:
       run:
         shell: bash
     env:
-      CCACHE_DIR: "${GITHUB_WORKSPACE}/.ccache"
+      CCACHE_DIR: "${{ github.workspace }}/.ccache"
       VELOX_DEPENDENCY_SOURCE: SYSTEM
       Protobuf_SOURCE: BUNDLED # can be removed after #10134 is merged
       simdjson_SOURCE: BUNDLED
@@ -109,7 +109,7 @@ jobs:
         # Some of the adapters dependencies are in the 'adapters' conda env
         shell: mamba run --no-capture-output -n adapters /usr/bin/bash -e {0}
         env:
-          LIBHDFS3_CONF: "${GITHUB_WORKSPACE}/scripts/hdfs-client.xml"
+          LIBHDFS3_CONF: "${{ github.workspace }}/scripts/hdfs-client.xml"
         working-directory: _build/release
         run: |
           ctest -j 8 --output-on-failure --no-tests=error -E "velox_exec_test|velox_hdfs_file_test|velox_s3"