Skip to content

Commit 90355f7

Browse files
authored
update velox tpch.sh script w.r.t cudf memory flags (#132)
This PR modifies the velox tpch benchmarking script with respect to the recent change to the existing cudf benchmarking flags.
1 parent 11fe85b commit 90355f7

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

velox/benchmarks/tpch.sh

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -194,15 +194,14 @@ run_tpch_single_benchmark() {
194194
num_drivers=${NUM_DRIVERS:-32}
195195
BENCHMARK_EXECUTABLE="$(get_tpch_benchmark_executable_path "$device_type")"
196196
CUDF_FLAGS=""
197-
VELOX_CUDF_FLAGS=""
198197
;;
199198
"gpu")
200199
num_drivers=${NUM_DRIVERS:-4}
201200
cudf_chunk_read_limit=$((1024 * 1024 * 1024 * 1))
202201
cudf_pass_read_limit=0
202+
cudf_memory_resource="async"
203203
BENCHMARK_EXECUTABLE="$(get_tpch_benchmark_executable_path "$device_type")"
204-
CUDF_FLAGS="--cudf_chunk_read_limit=${cudf_chunk_read_limit} --cudf_pass_read_limit=${cudf_pass_read_limit}"
205-
VELOX_CUDF_FLAGS="--velox_cudf_memory_resource=async"
204+
CUDF_FLAGS="--cudf_chunk_read_limit=${cudf_chunk_read_limit} --cudf_pass_read_limit=${cudf_pass_read_limit} --cudf_memory_resource=${cudf_memory_resource}"
206205
;;
207206
esac
208207

@@ -247,7 +246,6 @@ run_tpch_single_benchmark() {
247246
--num_drivers='"${num_drivers}"' \
248247
--preferred_output_batch_rows='"${output_batch_rows}"' \
249248
--max_output_batch_rows='"${output_batch_rows}"' \
250-
'"${VELOX_CUDF_FLAGS}"' \
251249
'"${CUDF_FLAGS}"' 2>&1 | \
252250
tee \"\$BASE_FILENAME\"
253251
chown \"${USER_ID}:${GROUP_ID}\" \"\$BASE_FILENAME\"

0 commit comments

Comments
 (0)