Skip to content

Commit 5100752

Browse files
committed
increase nofile ulimit if using sccache-dist
1 parent 4f1b22d commit 5100752

File tree

5 files changed

+30
-11
lines changed

5 files changed

+30
-11
lines changed

.github/workflows/conda-cpp-build.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ jobs:
175175
AWS_ACCESS_KEY_ID: "${{env.AWS_ACCESS_KEY_ID}}"
176176
AWS_SECRET_ACCESS_KEY: "${{env.AWS_SECRET_ACCESS_KEY}}"
177177
with:
178-
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}"
178+
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}" # zizmor: ignore[overprovisioned-secrets]
179179
cache-slug: "conda-py${{matrix.PY_VER}}-cuda${{matrix.CUDA_VER}}-${{matrix.ARCH}}"
180180
log-file: "${{ env.RAPIDS_ARTIFACTS_DIR }}/sccache.log"
181181
request-timeout: ${{ inputs.sccache-dist-request-timeout }}
@@ -194,8 +194,12 @@ jobs:
194194
# NEEDS alternative-gh-token-secret-name - API limits need to be for whatever token is used for upload/download. Repo token may be a different pool for rate limits.
195195
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
196196
- name: C++ build
197-
run: ${{ inputs.script }} # zizmor: ignore[template-injection]
197+
run: |
198+
if test -n "${SCCACHE_DIST_TOKEN_NAME:+x}"; then ulimit -n "$(ulimit -Hn)"; fi
199+
$INPUTS_SCRIPT
198200
env:
201+
INPUTS_SCRIPT: "${{ inputs.script }}"
202+
SCCACHE_DIST_TOKEN_NAME: "${{ inputs.sccache-dist-token-secret-name }}"
199203
STEP_NAME: "C++ build"
200204
# NEEDS alternative-gh-token-secret-name - may require a token with more permissions
201205
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]

.github/workflows/conda-cpp-tests.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ jobs:
219219
AWS_ACCESS_KEY_ID: "${{env.AWS_ACCESS_KEY_ID}}"
220220
AWS_SECRET_ACCESS_KEY: "${{env.AWS_SECRET_ACCESS_KEY}}"
221221
with:
222-
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}"
222+
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}" # zizmor: ignore[overprovisioned-secrets]
223223
cache-slug: "conda-py${{matrix.PY_VER}}-cuda${{matrix.CUDA_VER}}-${{matrix.ARCH}}"
224224
log-file: "${{ env.RAPIDS_ARTIFACTS_DIR }}/sccache.log"
225225
request-timeout: ${{ inputs.sccache-dist-request-timeout }}
@@ -238,8 +238,12 @@ jobs:
238238
# NEEDS alternative-gh-token-secret_name - API limits need to be for whatever token is used for upload/download. Repo token may be a different pool for rate limits.
239239
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
240240
- name: C++ tests
241-
run: ${{ inputs.script }} # zizmor: ignore[template-injection]
241+
run: |
242+
if test -n "${SCCACHE_DIST_TOKEN_NAME:+x}"; then ulimit -n "$(ulimit -Hn)"; fi
243+
$INPUTS_SCRIPT
242244
env:
245+
INPUTS_SCRIPT: "${{ inputs.script }}"
246+
SCCACHE_DIST_TOKEN_NAME: "${{ inputs.sccache-dist-token-secret-name }}"
243247
# NEEDS alternative-gh-token-secret-name - may require a token with more permissions
244248
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
245249
- name: Generate test report

.github/workflows/conda-python-tests.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ jobs:
224224
AWS_ACCESS_KEY_ID: "${{env.AWS_ACCESS_KEY_ID}}"
225225
AWS_SECRET_ACCESS_KEY: "${{env.AWS_SECRET_ACCESS_KEY}}"
226226
with:
227-
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}"
227+
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}" # zizmor: ignore[overprovisioned-secrets]
228228
cache-slug: "conda-py${{matrix.PY_VER}}-cuda${{matrix.CUDA_VER}}-${{matrix.ARCH}}"
229229
log-file: "${{ env.RAPIDS_ARTIFACTS_DIR }}/sccache.log"
230230
request-timeout: ${{ inputs.sccache-dist-request-timeout }}
@@ -243,8 +243,12 @@ jobs:
243243
# NEEDS alternative-gh-token-secret_name - API limits need to be for whatever token is used for upload/download. Repo token may be a different pool for rate limits.
244244
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
245245
- name: Python tests
246-
run: ${{ inputs.script }} # zizmor: ignore[template-injection]
246+
run: |
247+
if test -n "${SCCACHE_DIST_TOKEN_NAME:+x}"; then ulimit -n "$(ulimit -Hn)"; fi
248+
$INPUTS_SCRIPT
247249
env:
250+
INPUTS_SCRIPT: "${{ inputs.script }}"
251+
SCCACHE_DIST_TOKEN_NAME: "${{ inputs.sccache-dist-token-secret-name }}"
248252
# NEEDS alternative-gh-token-secret-name - may require a token with more permissions
249253
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
250254
- name: Generate test report

.github/workflows/wheels-build.yaml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ jobs:
241241
AWS_ACCESS_KEY_ID: "${{env.AWS_ACCESS_KEY_ID}}"
242242
AWS_SECRET_ACCESS_KEY: "${{env.AWS_SECRET_ACCESS_KEY}}"
243243
with:
244-
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}"
244+
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}" # zizmor: ignore[overprovisioned-secrets]
245245
cache-slug: "conda-py${{matrix.PY_VER}}-cuda${{matrix.CUDA_VER}}-${{matrix.ARCH}}"
246246
log-file: "${{ env.RAPIDS_ARTIFACTS_DIR }}/sccache.log"
247247
request-timeout: ${{ inputs.sccache-dist-request-timeout }}
@@ -260,8 +260,12 @@ jobs:
260260
# NEEDS alternative-gh-token-secret_name - API limits need to be for whatever token is used for upload/download. Repo token may be a different pool for rate limits.
261261
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
262262
- name: Build and repair the wheel
263-
run: ${{ inputs.script }} # zizmor: ignore[template-injection]
263+
run: |
264+
if test -n "${SCCACHE_DIST_TOKEN_NAME:+x}"; then ulimit -n "$(ulimit -Hn)"; fi
265+
$INPUTS_SCRIPT
264266
env:
267+
INPUTS_SCRIPT: "${{ inputs.script }}"
268+
SCCACHE_DIST_TOKEN_NAME: "${{ inputs.sccache-dist-token-secret-name }}"
265269
# NEEDS alternative-gh-token-secret-name - may require a token with more permissions
266270
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
267271
# Use a shell that loads the rc file so that we get the compiler settings

.github/workflows/wheels-test.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ jobs:
240240
AWS_ACCESS_KEY_ID: "${{env.AWS_ACCESS_KEY_ID}}"
241241
AWS_SECRET_ACCESS_KEY: "${{env.AWS_SECRET_ACCESS_KEY}}"
242242
with:
243-
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}"
243+
auth: "${{ secrets[inputs.sccache-dist-token-secret-name] }}" # zizmor: ignore[overprovisioned-secrets]
244244
cache-slug: "conda-py${{matrix.PY_VER}}-cuda${{matrix.CUDA_VER}}-${{matrix.ARCH}}"
245245
log-file: "${{ env.RAPIDS_ARTIFACTS_DIR }}/sccache.log"
246246
request-timeout: ${{ inputs.sccache-dist-request-timeout }}
@@ -260,12 +260,15 @@ jobs:
260260
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
261261

262262
- name: Run tests
263-
run: ${INPUTS_SCRIPT}
263+
run: |
264+
if test -n "${SCCACHE_DIST_TOKEN_NAME:+x}"; then ulimit -n "$(ulimit -Hn)"; fi
265+
$INPUTS_SCRIPT
264266
env:
267+
INPUTS_SCRIPT: "${{ inputs.script }}"
268+
SCCACHE_DIST_TOKEN_NAME: "${{ inputs.sccache-dist-token-secret-name }}"
265269
# NEEDS alternative-gh-token-secret-name - may require a token with more permissions
266270
GH_TOKEN: ${{ inputs.alternative-gh-token-secret-name && secrets[inputs.alternative-gh-token-secret-name] || github.token }} # zizmor: ignore[overprovisioned-secrets]
267271
RAPIDS_AUX_SECRET_1: ${{ inputs.rapids-aux-secret-1 != '' && secrets[inputs.rapids-aux-secret-1] || '' }} # zizmor: ignore[overprovisioned-secrets]
268-
INPUTS_SCRIPT: ${{ inputs.script }}
269272

270273
- name: Generate test report
271274
uses: test-summary/action@31493c76ec9e7aa675f1585d3ed6f1da69269a86 # v2.4

0 commit comments

Comments
 (0)