Skip to content

Commit 6ab3851

Browse files
committed
Drop check for cuFile version
This was only needed for batch and stream API checking. However as both APIs are part of CUDA 12.2+, which is now our hard requirement, there is no need to check for them or the cuFile version. So drop this logic.
1 parent d1bfd7e commit 6ab3851

File tree

3 files changed

+0
-27
lines changed

3 files changed

+0
-27
lines changed

cpp/CMakeLists.txt

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -109,20 +109,6 @@ else()
109109
OUTPUT_VARIABLE stream_output
110110
)
111111
message(STATUS "Found cuFile Stream API: ${cuFile_STREAM_API_FOUND}")
112-
try_compile(
113-
cuFile_VERSION_API_FOUND SOURCE_FROM_CONTENT
114-
version.cpp
115-
[[#include <cufile.h>
116-
int main() {
117-
int version;
118-
cuFileGetVersion(&version);
119-
return 0;
120-
}
121-
]]
122-
LINK_LIBRARIES CUDA::cuFile rt ${CMAKE_DL_LIBS}
123-
OUTPUT_VARIABLE version_output
124-
)
125-
message(STATUS "Found cuFile Version API: ${cuFile_VERSION_API_FOUND}")
126112
endif()
127113

128114
include(cmake/thirdparty/get_thread_pool.cmake)
@@ -188,7 +174,6 @@ target_compile_definitions(
188174
kvikio
189175
PUBLIC $<$<BOOL:${KvikIO_REMOTE_SUPPORT}>:KVIKIO_LIBCURL_FOUND>
190176
$<$<BOOL:${cuFile_FOUND}>:KVIKIO_CUFILE_FOUND>
191-
$<$<BOOL:${cuFile_VERSION_API_FOUND}>:KVIKIO_CUFILE_VERSION_API_FOUND>
192177
)
193178

194179
set_target_properties(

cpp/include/kvikio/shim/cufile.hpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,6 @@ class cuFileAPI {
4343
decltype(cuFileDriverOpen)* DriverOpen{nullptr};
4444
decltype(cuFileDriverClose)* DriverClose{nullptr};
4545

46-
// Don't call `GetVersion` directly, use `cuFileAPI::instance().version`.
47-
decltype(cuFileGetVersion)* GetVersion{nullptr};
48-
4946
public:
5047
int version{0};
5148

cpp/include/kvikio/shim/cufile_h_wrapper.hpp

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,3 @@ CUfileError_t cuFileDriverSetMaxCacheSize(...);
6363
CUfileError_t cuFileDriverSetMaxPinnedMemSize(...);
6464

6565
#endif
66-
67-
// If some cufile APIs aren't defined, we define some of the data types here.
68-
// Notice, this doesn't need to be ABI compatible with the cufile definitions and
69-
// the lack of definitions is not a problem because the linker will never look for
70-
// these symbols because the "real" function calls are made through the shim instance.
71-
72-
#ifndef KVIKIO_CUFILE_VERSION_API_FOUND
73-
CUfileError_t cuFileGetVersion(...);
74-
#endif

0 commit comments

Comments
 (0)