Skip to content

Commit 9e0b838

Browse files
Moving wheel builds to specified location and uploading build artifacts to Github (#222)
This work is towards moving build artifacts from `downloads.rapids.ai` to Github Artifact Store (see https://github.com/rapidsai/ops/issues/2982) As part of these changes, all wheel builds need to be in a specified temporary directory indicated by the environment variable `RAPIDS_WHEEL_BLD_OUTPUT_DIR` set on the `ci-wheel` Docker image used for building wheels. This lets us upload all wheel artifacts seamlessly to Github Artifacts.
1 parent 398fea0 commit 9e0b838

File tree

4 files changed

+22
-14
lines changed

4 files changed

+22
-14
lines changed

.github/workflows/build.yaml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ concurrency:
2929
jobs:
3030
conda-python-build:
3131
secrets: inherit
32-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
32+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.06
3333
with:
3434
build_type: ${{ inputs.build_type || 'branch' }}
3535
branch: ${{ inputs.branch }}
@@ -40,15 +40,15 @@ jobs:
4040
upload-conda:
4141
needs: conda-python-build
4242
secrets: inherit
43-
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@branch-25.04
43+
uses: rapidsai/shared-workflows/.github/workflows/conda-upload-packages.yaml@branch-25.06
4444
with:
4545
build_type: ${{ inputs.build_type || 'branch' }}
4646
branch: ${{ inputs.branch }}
4747
date: ${{ inputs.date }}
4848
sha: ${{ inputs.sha }}
4949
wheel-build:
5050
secrets: inherit
51-
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
51+
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.06
5252
with:
5353
build_type: ${{ inputs.build_type || 'branch' }}
5454
branch: ${{ inputs.branch }}
@@ -57,10 +57,14 @@ jobs:
5757
script: ci/build_wheel.sh
5858
# Package is pure Python and only ever requires one build.
5959
matrix_filter: 'map(select((.LINUX_VER | test("centos")|not))) | sort_by((.PY_VER | split(".") | map(tonumber))) | [.[-1] + {ARCH: "amd64"}]'
60+
wheel-name: jupyterlab-nvdashboard
61+
package-type: python
62+
pure-wheel: true
63+
append-cuda-suffix: false
6064
wheel-publish:
6165
needs: wheel-build
6266
secrets: inherit
63-
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@branch-25.04
67+
uses: rapidsai/shared-workflows/.github/workflows/wheels-publish.yaml@branch-25.06
6468
with:
6569
build_type: ${{ inputs.build_type || 'branch' }}
6670
branch: ${{ inputs.branch }}

.github/workflows/pr.yaml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,39 +18,43 @@ jobs:
1818
- wheel-build
1919
- wheel-tests
2020
secrets: inherit
21-
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-25.04
21+
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@branch-25.06
2222
checks:
2323
secrets: inherit
24-
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.04
24+
uses: rapidsai/shared-workflows/.github/workflows/checks.yaml@branch-25.06
2525
conda-python-build:
2626
needs: checks
2727
secrets: inherit
28-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.04
28+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-build.yaml@branch-25.06
2929
with:
3030
build_type: pull-request
3131
# This selects "ARCH=amd64 + the latest supported Python + CUDA".
3232
matrix_filter: map(select(.ARCH == "amd64")) | max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
3333
conda-python-tests:
3434
needs: conda-python-build
3535
secrets: inherit
36-
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.04
36+
uses: rapidsai/shared-workflows/.github/workflows/conda-python-tests.yaml@branch-25.06
3737
with:
3838
build_type: pull-request
3939
# This selects "ARCH=amd64 + the latest supported Python + CUDA".
4040
matrix_filter: map(select(.ARCH == "amd64")) | max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
4141
wheel-build:
4242
needs: checks
4343
secrets: inherit
44-
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.04
44+
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.06
4545
with:
4646
build_type: pull-request
4747
# This selects the latest supported Python + CUDA
4848
matrix_filter: max_by([(.PY_VER|split(".")|map(tonumber)), (.CUDA_VER|split(".")|map(tonumber))]) | [.]
4949
script: "ci/build_wheel.sh"
50+
wheel-name: jupyterlab-nvdashboard
51+
package-type: python
52+
pure-wheel: true
53+
append-cuda-suffix: false
5054
wheel-tests:
5155
needs: wheel-build
5256
secrets: inherit
53-
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.04
57+
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@branch-25.06
5458
with:
5559
build_type: pull-request
5660
# This selects the latest supported Python + CUDA

.github/workflows/trigger-breaking-change-alert.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
trigger-notifier:
1313
if: contains(github.event.pull_request.labels.*.name, 'breaking')
1414
secrets: inherit
15-
uses: rapidsai/shared-workflows/.github/workflows/breaking-change-alert.yaml@branch-25.04
15+
uses: rapidsai/shared-workflows/.github/workflows/breaking-change-alert.yaml@branch-25.06
1616
with:
1717
sender_login: ${{ github.event.sender.login }}
1818
sender_avatar: ${{ github.event.sender.avatar_url }}

ci/build_wheel.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,10 @@ rapids-logger "Begin py build"
3636
python -m pip install build
3737

3838
# Build the Python package
39-
python -m build -s -w
39+
python -m build -s -w --outdir "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}"
4040

41-
ci/validate_wheel.sh dist
41+
ci/validate_wheel.sh "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}"
4242

4343
rapids-logger "Uploading JupyterLab NVDashboard wheels to S3"
4444
# Upload Python wheels to S3
45-
RAPIDS_PY_WHEEL_NAME="${package_name}" RAPIDS_PY_WHEEL_PURE="1" rapids-upload-wheels-to-s3 dist
45+
RAPIDS_PY_WHEEL_NAME="${package_name}" RAPIDS_PY_WHEEL_PURE="1" rapids-upload-wheels-to-s3 python "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}"

0 commit comments

Comments
 (0)