-
Notifications
You must be signed in to change notification settings - Fork 607
Simplify type reflection implementation #7539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcrist
wants to merge
30
commits into
rapidsai:main
Choose a base branch
from
jcrist:simplify-reflection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a004b9c
Remove lingering cupy allocator setting
jcrist d87b398
Remove `in_internal_api` (move forward)
jcrist 1c8521b
Remove `api_return_sparse_array`/`api_base_return_sparse_array`
jcrist db07390
Drop some trivial contextmanager subclasses
jcrist 56a3640
Consolidate `ProcessReturn`
jcrist 3940964
Merge `ProcessReturn` into `InternalAPIContextBase`
jcrist f14f616
Remove duplicate *ReturnAny, remove mixin class
jcrist 1697a47
Remove *generic decorators
jcrist d59849a
Rip out ProcessEnter classes
jcrist ed547db
Couple `set_n_features_in` to `set_output_type`
jcrist dd1b90a
Remove `needs_self`
jcrist cd48af1
Add `reflect`, simplify frontend
jcrist 11df678
Prepare to rip out `set_api_output_type`
jcrist f7b2c43
Rip out last external ref to `root_cm`
jcrist c6ddca8
Reorg output handling into `cuml.internals.outputs`
jcrist ddfb630
Simplify and unify `output_type` validation
jcrist 4fc6645
Remove `root_cm`, `api_context_managers`
jcrist 1353aeb
Simplify `skip=True` case
jcrist f3f968e
Explicit decorators
jcrist 65df8e4
Explicit decorators for MG models
jcrist 2b3929c
Remove base metaclass and old decorator names
jcrist df7799f
Update doc refs
jcrist b935d76
Improve docstrings
jcrist d58ac80
Rename `test_module_config.py -> test_reflection.py`
jcrist a44e6df
Consolidate and expand reflection tests
jcrist fd6bddd
Fixup for SpectralClustering change that snuck in on rebase
jcrist a823909
Merge branch 'main' into simplify-reflection
jcrist ecda0c8
Merge branch 'main' into simplify-reflection
jcrist 6e78370
Remove `type_utils`
jcrist 2e13e1d
Remove `base_return_types`
jcrist File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These functions were only ever demonstrated from the top-level namespace, but did indeed contain the old filename in the full path.
If necessary we can add a shim
cuml.internals.memory_utilsfile to keep around the old import paths for a deprecation cycle. I doubt it's needed, but 🤷.