Skip to content

Conversation

@trxcllnt
Copy link
Contributor

@trxcllnt trxcllnt commented Nov 4, 2025

Description

RAPIDS has deployed an autoscaling cloud build cluster that can be used to accelerate building large RAPIDS projects.

This PR updates the conda and wheel builds to use the build cluster.

This contributes to rapidsai/build-planning#228.

@trxcllnt trxcllnt requested review from a team as code owners November 4, 2025 18:35
@trxcllnt trxcllnt added the improvement Improves an existing functionality label Nov 4, 2025
@trxcllnt trxcllnt requested a review from AyodeAwe November 4, 2025 18:35
@trxcllnt trxcllnt added the non-breaking Introduces a non-breaking change label Nov 4, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR enables the use of RAPIDS' autoscaling cloud build cluster (sccache-dist) to accelerate conda and wheel builds across all CI workflows.

Key Changes:

  • Added sccache-dist-token-secret-name: GIST_REPO_READ_ORG_GITHUB_TOKEN to all conda and wheel build/test jobs in workflows to authenticate with the distributed build cluster
  • Added node_type: cpu8 to C++ and wheel build jobs to specify appropriate node types for the build cluster
  • Set SCCACHE_NO_DIST_COMPILE=1 in cmake/rapids_config.cmake to disable distributed compilation for CMake's compiler tests (optimization to avoid connection overhead for trivial test compilations)
  • Added NVCC_APPEND_FLAGS environment variable with default empty string in conda recipes to prevent build failures when the variable is unset in the build environment

The changes are consistent across all three workflow files (build, PR, test) and align with RAPIDS' broader infrastructure initiative to use GCC 14 and improve build performance.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • All changes are configuration-only, following established RAPIDS patterns for sccache-dist integration. The additions are non-breaking: node_type and sccache-dist-token-secret-name are optional parameters handled by shared workflows, SCCACHE_NO_DIST_COMPILE is a standard optimization, and the NVCC_APPEND_FLAGS default value fix prevents potential build failures. No logic changes or new code paths introduced.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/build.yaml 5/5 Added sccache-dist-token-secret-name and node_type: cpu8 to all conda and wheel build jobs for distributed compilation support
.github/workflows/pr.yaml 5/5 Added sccache-dist-token-secret-name and node_type: cpu8 to all build and test jobs for distributed compilation in PR workflows
cmake/rapids_config.cmake 5/5 Set SCCACHE_NO_DIST_COMPILE=1 to disable sccache-dist for CMake compiler tests, preventing connection overhead for simple test compilations
conda/recipes/libwholegraph/recipe.yaml 5/5 Added NVCC_APPEND_FLAGS environment variable with default empty string to prevent build failures when variable is unset

Sequence Diagram

sequenceDiagram
    participant GH as GitHub Actions
    participant Node as Build Node (cpu8)
    participant SCC as sccache-dist Cluster
    participant S3 as S3 Cache
    
    GH->>GH: Authenticate with GIST_REPO_READ_ORG_GITHUB_TOKEN
    GH->>Node: Start build job on cpu8 node
    Node->>Node: Set SCCACHE_NO_DIST_COMPILE=1 (CMake config)
    Node->>Node: Run CMake compiler tests (local only)
    Node->>Node: Unset SCCACHE_NO_DIST_COMPILE
    Node->>SCC: Connect to sccache-dist cluster
    SCC->>S3: Check cache for compiled objects
    alt Cache Hit
        S3-->>SCC: Return cached objects
        SCC-->>Node: Deliver cached compilation results
    else Cache Miss
        Node->>SCC: Submit compilation tasks
        SCC->>SCC: Distribute compilation across cluster
        SCC-->>Node: Return compiled objects
        SCC->>S3: Store results in cache
    end
    Node->>Node: Link final artifacts
    Node-->>GH: Upload build artifacts
Loading

6 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@trxcllnt trxcllnt added the DO NOT MERGE Hold off on merging; see PR for details label Nov 5, 2025
greptile-apps[bot]

This comment was marked as outdated.

@rapidsai rapidsai deleted a comment from greptile-apps bot Nov 7, 2025
greptile-apps[bot]

This comment was marked as outdated.

@rapidsai rapidsai deleted a comment from greptile-apps bot Nov 7, 2025
@rapidsai rapidsai deleted a comment from greptile-apps bot Nov 7, 2025
@rapidsai rapidsai deleted a comment from greptile-apps bot Nov 7, 2025
@rapidsai rapidsai deleted a comment from greptile-apps bot Nov 7, 2025
greptile-apps[bot]

This comment was marked as duplicate.

@greptile-apps

This comment was marked as outdated.

greptile-apps[bot]

This comment was marked as outdated.

greptile-apps[bot]

This comment was marked as outdated.

@rapidsai rapidsai deleted a comment from greptile-apps bot Nov 11, 2025
greptile-apps[bot]

This comment was marked as outdated.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

This reverts commit 59696cd.
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@trxcllnt trxcllnt removed the DO NOT MERGE Hold off on merging; see PR for details label Nov 15, 2025
@trxcllnt trxcllnt changed the base branch from main to release/25.12 November 17, 2025 18:19
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 files reviewed, no comments

Edit Code Review Agent Settings | Greptile
React with 👍 or 👎 to share your feedback on this new summary format

Copy link
Contributor

@rockhowse rockhowse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI changes are consistent with those seen in other repos undergoing sccache-dist work.

CI errors appear unrelated to this PR.

@trxcllnt
Copy link
Contributor Author

Yeah, @alexbarghi-nv mentioned they're being fixed in another PR and that it's fine to merge this.

@trxcllnt trxcllnt merged commit ec608df into rapidsai:release/25.12 Nov 20, 2025
70 of 76 checks passed
@trxcllnt trxcllnt deleted the fea/use-sccache-build-cluster branch November 20, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants