add comment

Menna · dweomer · commit 990c403c4a7a · 2020-06-22T16:20:13.000-07:00
diff --git a/pkg/upgrade/handle_batch.go b/pkg/upgrade/handle_batch.go
@@ -95,6 +95,7 @@ func (ctl *Controller) handleJobs(ctx context.Context) error {
 			}
 			return obj, enqueueOrDelete(jobs, obj, upgradejob.ConditionComplete)
 		}
+		// if the job is hasn't failed or completed but the job Node is not on the applying list, consider it running out-of-turn and delete it
 		if i := sort.SearchStrings(plan.Status.Applying, nodeName); i == len(plan.Status.Applying) ||
 			(i < len(plan.Status.Applying) && plan.Status.Applying[i] != nodeName) {
 			return obj, deleteJob(jobs, obj, metav1.DeletePropagationBackground)

Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,7 @@ func (ctl *Controller) handleJobs(ctx context.Context) error {`
`95`	`95`	`}`
`96`	`96`	`return obj, enqueueOrDelete(jobs, obj, upgradejob.ConditionComplete)`
`97`	`97`	`}`
	`98`	`+ // if the job is hasn't failed or completed but the job Node is not on the applying list, consider it running out-of-turn and delete it`
`98`	`99`	`if i := sort.SearchStrings(plan.Status.Applying, nodeName); i == len(plan.Status.Applying) \|\|`
`99`	`100`	`(i < len(plan.Status.Applying) && plan.Status.Applying[i] != nodeName) {`
`100`	`101`	`return obj, deleteJob(jobs, obj, metav1.DeletePropagationBackground)`