Skip to content

Commit 063bba3

Browse files
Add Envs and EnvFroms to container (#112)
* Flip parameters to match API * Add Envs and EnvFroms to container * Update generated code
1 parent 6f0145c commit 063bba3

File tree

4 files changed

+23
-6
lines changed

4 files changed

+23
-6
lines changed

main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ func Run(_ *cli.Context) {
9090
logrus.SetLevel(logrus.DebugLevel)
9191
logrus.SetReportCaller(true)
9292
}
93-
cfg, err := clientcmd.BuildConfigFromFlags(kubeConfig, masterURL)
93+
cfg, err := clientcmd.BuildConfigFromFlags(masterURL, kubeConfig)
9494
if err != nil {
9595
logrus.Fatal(err)
9696
}

pkg/apis/upgrade.cattle.io/v1/types.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,11 @@ type PlanStatus struct {
5757

5858
// ContainerSpec is a simplified container template.
5959
type ContainerSpec struct {
60-
Image string `json:"image,omitempty"`
61-
Command []string `json:"command,omitempty"`
62-
Args []string `json:"args,omitempty"`
60+
Image string `json:"image,omitempty"`
61+
Command []string `json:"command,omitempty"`
62+
Args []string `json:"args,omitempty"`
63+
Env []corev1.EnvVar `json:"envs,omitempty"`
64+
EnvFrom []corev1.EnvFromSource `json:"envFrom,omitempty"`
6365
}
6466

6567
// DrainSpec encapsulates `kubectl drain` parameters minus node/pod selectors.

pkg/apis/upgrade.cattle.io/v1/zz_generated_deepcopy.go

Lines changed: 14 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/upgrade/container/container.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func New(name string, spec upgradeapiv1.ContainerSpec, opt ...Option) corev1.Con
8686
{Name: "host-root", MountPath: "/host"},
8787
{Name: "pod-info", MountPath: "/run/system-upgrade/pod", ReadOnly: true},
8888
},
89-
Env: []corev1.EnvVar{{
89+
Env: append([]corev1.EnvVar{{
9090
Name: "SYSTEM_UPGRADE_NODE_NAME",
9191
ValueFrom: &corev1.EnvVarSource{
9292
FieldRef: &corev1.ObjectFieldSelector{
@@ -107,7 +107,8 @@ func New(name string, spec upgradeapiv1.ContainerSpec, opt ...Option) corev1.Con
107107
FieldPath: "metadata.uid",
108108
},
109109
},
110-
}},
110+
}}, spec.Env...),
111+
EnvFrom: spec.EnvFrom,
111112
}
112113
for _, fn := range opt {
113114
fn(&container)

0 commit comments

Comments
 (0)