Skip to content

Commit 5c2e887

Browse files
committed
Run cargo fmt.
1 parent 1f00c0a commit 5c2e887

File tree

14 files changed

+205
-85
lines changed

14 files changed

+205
-85
lines changed

benches/svm_dense.rs

Lines changed: 37 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ mod svm_dense {
2020
let mut problem = FeatureVector::from(&svm);
2121
let problem_mut = problem.features();
2222

23-
for i in 0 .. num_attributes {
23+
for i in 0..num_attributes {
2424
problem_mut[i as usize] = i as f32;
2525
}
2626

@@ -30,44 +30,68 @@ mod svm_dense {
3030
// RBF
3131

3232
#[bench]
33-
fn predict_rbf_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "rbf", 128, 16)); }
33+
fn predict_rbf_sv128_attr16(b: &mut Bencher) {
34+
b.iter(produce_testcase("c_svc", "rbf", 128, 16));
35+
}
3436

3537
#[bench]
36-
fn predict_rbf_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "rbf", 1024, 16)); }
38+
fn predict_rbf_sv1024_attr16(b: &mut Bencher) {
39+
b.iter(produce_testcase("c_svc", "rbf", 1024, 16));
40+
}
3741

3842
#[bench]
39-
fn predict_rbf_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "rbf", 1024, 1024)); }
43+
fn predict_rbf_sv1024_attr1024(b: &mut Bencher) {
44+
b.iter(produce_testcase("c_svc", "rbf", 1024, 1024));
45+
}
4046

4147
// Linear
4248

4349
#[bench]
44-
fn predict_linear_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "linear", 128, 16)); }
50+
fn predict_linear_sv128_attr16(b: &mut Bencher) {
51+
b.iter(produce_testcase("c_svc", "linear", 128, 16));
52+
}
4553

4654
#[bench]
47-
fn predict_linear_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "linear", 1024, 16)); }
55+
fn predict_linear_sv1024_attr16(b: &mut Bencher) {
56+
b.iter(produce_testcase("c_svc", "linear", 1024, 16));
57+
}
4858

4959
#[bench]
50-
fn predict_linear_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "linear", 1024, 1024)); }
60+
fn predict_linear_sv1024_attr1024(b: &mut Bencher) {
61+
b.iter(produce_testcase("c_svc", "linear", 1024, 1024));
62+
}
5163

5264
// Poly
5365

5466
#[bench]
55-
fn predict_poly_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "polynomial", 128, 16)); }
67+
fn predict_poly_sv128_attr16(b: &mut Bencher) {
68+
b.iter(produce_testcase("c_svc", "polynomial", 128, 16));
69+
}
5670

5771
#[bench]
58-
fn predict_poly_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "polynomial", 1024, 16)); }
72+
fn predict_poly_sv1024_attr16(b: &mut Bencher) {
73+
b.iter(produce_testcase("c_svc", "polynomial", 1024, 16));
74+
}
5975

6076
#[bench]
61-
fn predict_poly_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "polynomial", 1024, 1024)); }
77+
fn predict_poly_sv1024_attr1024(b: &mut Bencher) {
78+
b.iter(produce_testcase("c_svc", "polynomial", 1024, 1024));
79+
}
6280

6381
// Sigmoid
6482

6583
#[bench]
66-
fn predict_sigmoid_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "sigmoid", 128, 16)); }
84+
fn predict_sigmoid_sv128_attr16(b: &mut Bencher) {
85+
b.iter(produce_testcase("c_svc", "sigmoid", 128, 16));
86+
}
6787

6888
#[bench]
69-
fn predict_sigmoid_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "sigmoid", 1024, 16)); }
89+
fn predict_sigmoid_sv1024_attr16(b: &mut Bencher) {
90+
b.iter(produce_testcase("c_svc", "sigmoid", 1024, 16));
91+
}
7092

7193
#[bench]
72-
fn predict_sigmoid_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "sigmoid", 1024, 1024)); }
94+
fn predict_sigmoid_sv1024_attr1024(b: &mut Bencher) {
95+
b.iter(produce_testcase("c_svc", "sigmoid", 1024, 1024));
96+
}
7397
}

benches/svm_sparse.rs

Lines changed: 38 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ mod util;
99

1010
mod svm_sparse {
1111
use crate::test::Bencher;
12-
use ffsvm::{Predict, FeatureVector, SparseSVM};
12+
use ffsvm::{FeatureVector, Predict, SparseSVM};
1313
use std::convert::TryFrom;
1414

1515
/// Produces a test case run for benchmarking
@@ -20,7 +20,7 @@ mod svm_sparse {
2020
let mut problem = FeatureVector::from(&svm);
2121
let problem_mut = problem.features();
2222

23-
for i in 0 .. num_attributes {
23+
for i in 0..num_attributes {
2424
problem_mut[i as usize] = i as f32;
2525
}
2626

@@ -30,45 +30,68 @@ mod svm_sparse {
3030
// RBF
3131

3232
#[bench]
33-
fn predict_rbf_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "rbf", 128, 16)); }
33+
fn predict_rbf_sv128_attr16(b: &mut Bencher) {
34+
b.iter(produce_testcase("c_svc", "rbf", 128, 16));
35+
}
3436

3537
#[bench]
36-
fn predict_rbf_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "rbf", 1024, 16)); }
38+
fn predict_rbf_sv1024_attr16(b: &mut Bencher) {
39+
b.iter(produce_testcase("c_svc", "rbf", 1024, 16));
40+
}
3741

3842
#[bench]
39-
fn predict_rbf_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "rbf", 1024, 1024)); }
43+
fn predict_rbf_sv1024_attr1024(b: &mut Bencher) {
44+
b.iter(produce_testcase("c_svc", "rbf", 1024, 1024));
45+
}
4046

4147
// Linear
4248

4349
#[bench]
44-
fn predict_linear_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "linear", 128, 16)); }
50+
fn predict_linear_sv128_attr16(b: &mut Bencher) {
51+
b.iter(produce_testcase("c_svc", "linear", 128, 16));
52+
}
4553

4654
#[bench]
47-
fn predict_linear_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "linear", 1024, 16)); }
55+
fn predict_linear_sv1024_attr16(b: &mut Bencher) {
56+
b.iter(produce_testcase("c_svc", "linear", 1024, 16));
57+
}
4858

4959
#[bench]
50-
fn predict_linear_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "linear", 1024, 1024)); }
60+
fn predict_linear_sv1024_attr1024(b: &mut Bencher) {
61+
b.iter(produce_testcase("c_svc", "linear", 1024, 1024));
62+
}
5163

5264
// Poly
5365

5466
#[bench]
55-
fn predict_poly_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "polynomial", 128, 16)); }
67+
fn predict_poly_sv128_attr16(b: &mut Bencher) {
68+
b.iter(produce_testcase("c_svc", "polynomial", 128, 16));
69+
}
5670

5771
#[bench]
58-
fn predict_poly_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "polynomial", 1024, 16)); }
72+
fn predict_poly_sv1024_attr16(b: &mut Bencher) {
73+
b.iter(produce_testcase("c_svc", "polynomial", 1024, 16));
74+
}
5975

6076
#[bench]
61-
fn predict_poly_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "polynomial", 1024, 1024)); }
77+
fn predict_poly_sv1024_attr1024(b: &mut Bencher) {
78+
b.iter(produce_testcase("c_svc", "polynomial", 1024, 1024));
79+
}
6280

6381
// Sigmoid
6482

6583
#[bench]
66-
fn predict_sigmoid_sv128_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "sigmoid", 128, 16)); }
84+
fn predict_sigmoid_sv128_attr16(b: &mut Bencher) {
85+
b.iter(produce_testcase("c_svc", "sigmoid", 128, 16));
86+
}
6787

6888
#[bench]
69-
fn predict_sigmoid_sv1024_attr16(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "sigmoid", 1024, 16)); }
89+
fn predict_sigmoid_sv1024_attr16(b: &mut Bencher) {
90+
b.iter(produce_testcase("c_svc", "sigmoid", 1024, 16));
91+
}
7092

7193
#[bench]
72-
fn predict_sigmoid_sv1024_attr1024(b: &mut Bencher) { b.iter(produce_testcase("c_svc", "sigmoid", 1024, 1024)); }
73-
94+
fn predict_sigmoid_sv1024_attr1024(b: &mut Bencher) {
95+
b.iter(produce_testcase("c_svc", "sigmoid", 1024, 1024));
96+
}
7497
}

benches/util.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ pub fn random_dense<'b>(svm_type: &'b str, kernel_type: &'b str, total_sv: u32,
1010
total_sv,
1111
gamma: Some(rng.gen::<f32>()),
1212
coef0: Some(rng.gen::<f32>()),
13-
degree: Some(rng.gen_range(1 .. 10)),
13+
degree: Some(rng.gen_range(1..10)),
1414
nr_class: 2,
1515
rho: vec![rng.gen::<f64>()],
1616
label: vec![0, 1],
@@ -19,10 +19,10 @@ pub fn random_dense<'b>(svm_type: &'b str, kernel_type: &'b str, total_sv: u32,
1919
nr_sv: vec![total_sv / 2, total_sv / 2],
2020
};
2121

22-
let vectors = (0 .. total_sv)
22+
let vectors = (0..total_sv)
2323
.map(|_| SupportVector {
2424
coefs: vec![rng.gen::<f32>()],
25-
features: (0 .. attr)
25+
features: (0..attr)
2626
.map(|i| Attribute {
2727
index: i,
2828
value: rng.gen::<f32>(),

src/errors.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,13 @@ pub enum Error {
5151
// }
5252

5353
impl From<ParseFloatError> for Error {
54-
fn from(_e: ParseFloatError) -> Self { Self::Parsing("ParseFloatError".to_owned()) }
54+
fn from(_e: ParseFloatError) -> Self {
55+
Self::Parsing("ParseFloatError".to_owned())
56+
}
5557
}
5658

5759
impl From<ParseIntError> for Error {
58-
fn from(_: ParseIntError) -> Self { Self::Parsing("ParseIntError".to_owned()) }
60+
fn from(_: ParseIntError) -> Self {
61+
Self::Parsing("ParseIntError".to_owned())
62+
}
5963
}

src/parser.rs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,21 @@ pub struct ModelFile<'a> {
6161
impl<'a> ModelFile<'a> {
6262
#[doc(hidden)]
6363
#[must_use]
64-
pub const fn new(header: Header<'a>, vectors: Vec<SupportVector>) -> Self { Self { header, vectors } }
64+
pub const fn new(header: Header<'a>, vectors: Vec<SupportVector>) -> Self {
65+
Self { header, vectors }
66+
}
6567

6668
#[doc(hidden)]
6769
#[must_use]
68-
pub const fn header(&self) -> &Header { &self.header }
70+
pub const fn header(&self) -> &Header {
71+
&self.header
72+
}
6973

7074
#[doc(hidden)]
7175
#[must_use]
72-
pub fn vectors(&self) -> &[SupportVector] { self.vectors.as_slice() }
76+
pub fn vectors(&self) -> &[SupportVector] {
77+
self.vectors.as_slice()
78+
}
7379
}
7480

7581
#[doc(hidden)]

src/sparse.rs

Lines changed: 21 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,17 @@ impl<T> SparseVector<T>
2121
where
2222
T: Clone + Copy + Default,
2323
{
24-
pub const fn new() -> Self { Self { entries: Vec::new() } }
24+
pub const fn new() -> Self {
25+
Self { entries: Vec::new() }
26+
}
2527

26-
pub fn clear(&mut self) { self.entries.clear(); }
28+
pub fn clear(&mut self) {
29+
self.entries.clear();
30+
}
2731

28-
pub const fn iter(&self) -> SparseVectorIter<'_, T> { SparseVectorIter { vector: self, index: 0 } }
32+
pub const fn iter(&self) -> SparseVectorIter<'_, T> {
33+
SparseVectorIter { vector: self, index: 0 }
34+
}
2935
}
3036

3137
/// Basic iterator struct to go over matrix
@@ -120,10 +126,14 @@ where
120126
}
121127
}
122128

123-
pub fn row(&self, row: usize) -> &SparseVector<T> { &self.vectors[row] }
129+
pub fn row(&self, row: usize) -> &SparseVector<T> {
130+
&self.vectors[row]
131+
}
124132

125133
#[inline]
126-
pub const fn row_iter(&self) -> SparseMatrixIter<'_, T> { SparseMatrixIter { matrix: self, index: 0 } }
134+
pub const fn row_iter(&self) -> SparseMatrixIter<'_, T> {
135+
SparseMatrixIter { matrix: self, index: 0 }
136+
}
127137
}
128138

129139
impl<T> Index<(usize, usize)> for SparseMatrix<T>
@@ -132,14 +142,18 @@ where
132142
{
133143
type Output = T;
134144

135-
fn index(&self, index: (usize, usize)) -> &T { &self.vectors[index.0][index.1] }
145+
fn index(&self, index: (usize, usize)) -> &T {
146+
&self.vectors[index.0][index.1]
147+
}
136148
}
137149

138150
impl<T> IndexMut<(usize, usize)> for SparseMatrix<T>
139151
where
140152
T: Copy + Sized + Default,
141153
{
142-
fn index_mut(&mut self, index: (usize, usize)) -> &mut T { &mut self.vectors[index.0][index.1] }
154+
fn index_mut(&mut self, index: (usize, usize)) -> &mut T {
155+
&mut self.vectors[index.0][index.1]
156+
}
143157
}
144158

145159
/// Basic iterator struct to go over matrix

src/svm/core/dense.rs

Lines changed: 19 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,8 @@ impl DenseSVM {
6060
///
6161
/// If the label was found its index returned in the [`Option`], otherwise `None`
6262
/// is returned.
63-
#[must_use] pub fn class_index_for_label(&self, label: i32) -> Option<usize> {
63+
#[must_use]
64+
pub fn class_index_for_label(&self, label: i32) -> Option<usize> {
6465
for (i, class) in self.classes.iter().enumerate() {
6566
if class.label != label {
6667
continue;
@@ -84,7 +85,8 @@ impl DenseSVM {
8485
///
8586
/// If the index was found it is returned in the [`Option`], otherwise `None`
8687
/// is returned.
87-
#[must_use] pub fn class_label_for_index(&self, index: usize) -> Option<i32> {
88+
#[must_use]
89+
pub fn class_label_for_index(&self, index: usize) -> Option<i32> {
8890
if index >= self.classes.len() {
8991
None
9092
} else {
@@ -116,7 +118,9 @@ impl DenseSVM {
116118
}
117119

118120
/// Based on kernel values, computes the decision values for this problem.
119-
pub(crate) fn compute_classification_values(&self, problem: &mut FeatureVector<VecSimd<f32x8>>) { compute_classification_values_impl!(self, problem) }
121+
pub(crate) fn compute_classification_values(&self, problem: &mut FeatureVector<VecSimd<f32x8>>) {
122+
compute_classification_values_impl!(self, problem)
123+
}
120124

121125
/// Based on kernel values, computes the decision values for this problem.
122126
pub(crate) fn compute_regression_values(&self, problem: &mut FeatureVector<VecSimd<f32x8>>) {
@@ -132,10 +136,16 @@ impl DenseSVM {
132136
}
133137

134138
/// Returns number of attributes, reflecting the libSVM model.
135-
#[must_use] pub const fn attributes(&self) -> usize { self.num_attributes }
139+
#[must_use]
140+
pub const fn attributes(&self) -> usize {
141+
self.num_attributes
142+
}
136143

137144
/// Returns number of classes, reflecting the libSVM model.
138-
#[must_use] pub fn classes(&self) -> usize { self.classes.len() }
145+
#[must_use]
146+
pub fn classes(&self) -> usize {
147+
self.classes.len()
148+
}
139149
}
140150

141151
impl Predict<VecSimd<f32x8>> for DenseSVM {
@@ -161,7 +171,9 @@ impl Predict<VecSimd<f32x8>> for DenseSVM {
161171
}
162172
}
163173

164-
fn predict_probability(&self, problem: &mut FeatureVector<VecSimd<f32x8>>) -> Result<(), Error> { predict_probability_impl!(self, problem) }
174+
fn predict_probability(&self, problem: &mut FeatureVector<VecSimd<f32x8>>) -> Result<(), Error> {
175+
predict_probability_impl!(self, problem)
176+
}
165177
}
166178

167179
impl<'a> TryFrom<&'a str> for DenseSVM {
@@ -190,7 +202,7 @@ impl<'a> TryFrom<&'a ModelFile<'_>> for DenseSVM {
190202
let stop_offset = start_offset + *num_sv_per_class as usize;
191203

192204
// Set support vector and coefficients
193-
for (i_vector, vector) in vectors[start_offset .. stop_offset].iter().enumerate() {
205+
for (i_vector, vector) in vectors[start_offset..stop_offset].iter().enumerate() {
194206
let mut last_attribute = None;
195207

196208
// Set support vectors

0 commit comments

Comments
 (0)