ci(t3x): add fork-runnable PR/main verify gate - #24
Merged
Conversation
Upstream's ci.yml runs on blacksmith-* runners the fork can't access, so fork PRs currently get no checks and "green" was only ever self-attested by the resolve job. Add t3x-ci.yml: typecheck/lint/test on ubuntu-latest, triggered on pull_request (gates feature PRs), push to main (post-sync verification), and push to t3x/sync-** (independent gate for conflicting sync PRs, which pull_request can't build a merge ref for). All three checks run each time so a single run reports every failure. Also list t3x-sync-resolve.yml + t3x-ci.yml in SEAMS.md's fork-owned files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Upstream's
ci.ymlruns onblacksmith-*runners the fork can't access, so fork PRs currently get no checks — the "no independent CI gate" gap flagged in the review of the last sync PR (#22). Until now, "green" on a sync was only self-attested by the resolve job.What
New fork-owned workflow
.github/workflows/t3x-ci.yml—vp run typecheck / lint / testonubuntu-latest:pull_request→ gates every feature PR (like this one).pushtomain→ post-sync verification that landed main is green.pushtot3x/sync-**→ independent gate for sync branches (a conflicting sync PR can't build a merge ref, sopull_requestnever fires on it).All three checks run each time (
if: ${{ !cancelled() }}) so one run reports every failure. Minimalcontents: readpermissions, no secrets. Also listedt3x-sync-resolve.yml+t3x-ci.ymlinSEAMS.md's fork-owned files.Self-test
This PR adds the workflow, so the
t3x fork CIcheck on this very PR is the proof it works — merging once it's green.🤖 Generated with Claude Code