Show original NPM exception

[MaklTa]

When quinoa fails during the startup due to the npm build, it only logs a generic message. It would be great to see the root cause. Otherwise I have to run the npm run build in the webui folder manually.

Could you please print the root cause?

Execution failed for task ':quarkusBuild'.
> io.quarkus.builder.BuildException: Build failure: Build failed due to errors
        [error]: Build step io.quarkiverse.quinoa.deployment.QuinoaProcessor#processBuild threw an exception: java.lang.RuntimeException: Error in Quinoa while running package manager build command: npm run build
        at io.quarkiverse.quinoa.deployment.PackageManager.build(PackageManager.java:60)
        at io.quarkiverse.quinoa.deployment.QuinoaProcessor.processBuild(QuinoaProcessor.java:126)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:566)
        at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:925)
        at io.quarkus.builder.BuildContext.run(BuildContext.java:277)
        at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18)
        at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449)
        at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478)
        at java.base/java.lang.Thread.run(Thread.java:829)
        at org.jboss.threads.JBossThread.run(JBossThread.java:501)

[melloware]

@MaklTa if you want look at where that is being thrown a PR would be welcome!

[m-krebs]

The error is thrown at PackageManagerRunner.java#L92.

The problem with the current code is the way the execute of npm commands works. Currently exec is a boolean returning method. So there is no way to return the build error message to its calling parent right now.

A possible solution (not really sure if viable) would be to throw an exception instead of returning false.

[melloware]

Couldn't we just do a better job of capturing the output in the exec method?

quarkus-quinoa/deployment/src/main/java/io/quarkiverse/quinoa/deployment/packagemanager/PackageManagerRunner.java

Lines 231 to 257 in 95aea5d

	private boolean exec(PackageManager.Command command) {
	Process process;
	HandleOutput handleOutput = null;
	try {
	final ProcessBuilder processBuilder = new ProcessBuilder();
	if (!command.envs.isEmpty()) {
	processBuilder.environment().putAll(command.envs);
	}
	process = processBuilder
	.directory(directory.toFile())
	.command(runner(command))
	.redirectErrorStream(true)
	.start();
	handleOutput = new HandleOutput(process.getInputStream(), consoleInstalledBuildItem, loggingSetupBuildItem);
	handleOutput.run();
	process.waitFor();
	} catch (IOException e) {
	throw new RuntimeException("Input/Output error while executing command.", e);
	} catch (InterruptedException e) {
	return false;
	} finally {
	if (handleOutput != null) {
	handleOutput.close();
	}
	}
	return process.exitValue() == 0;
	}

[m-krebs]

That might be a good idea, as handleOutput currently isn't really used "to handle output".

[melloware]

@m-krebs yeah if processCode != 0 i think we should dump the output to LOG.error

[ia3andy]

But it always print the command logs in the output no? So the exception don't have the actual error which can be very long but you just have to scroll up to find it in theory?

[melloware]

i think it gets turbo compacted? so it lost

[ia3andy]

Ok then it surely makes sense to do something about it! But I always remembered seeing the errors in the log, so please check it before