-
Notifications
You must be signed in to change notification settings - Fork 127
Open
Labels
Description
Quantum volume never really fit into Cirq, with the library code getting shuffled around (eventually landing in contrib
) and the driver scripts landing in examples/advanced
. It is the only advanced example. This also limits our ability to extend qvol and try various improvements or different metrics. It would be a good study to include in ReCirq
- move things over
- use data collection idioms for driver script
- document qvol with a notebook
- profit
Metadata
Metadata
Assignees
Labels
Type
Projects
Milestone
Relationships
Development
Select code repository
Activity
KevinVillela commentedon Apr 15, 2020
Started looking at this today. Couple of quick questions:
Thanks!
mpharrigan commentedon Apr 21, 2020
Actually, it might make sense to put this in a folder called
benchmarks/
in anticipation of future expansionThere should be an end-to-end notebook demonstrating a complete experiment which serves as an integration tests. The "library functionality" should have unit tests, as normal
Yes please
It might make sense to have it as application-specific code now but be cognizant of how it can be generalized to help everyone